diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2020-11-30 19:46:23 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-12-10 00:47:10 +0000 |
| commit | 5a0795edcb36ac1ad8ccb9618c8844c555e9264e (patch) | |
| tree | 306136ec4aee933e9f07279c7a6a6fa8be69ed93 /board/drawcia | |
| parent | 1797020481b8db91aa9a6092b9db52043695d514 (diff) | |
| download | chrome-ec-5a0795edcb36ac1ad8ccb9618c8844c555e9264e.tar.gz | |
drawcia: Update OCPC PID constants
This commit updates the PID constants for drawcia to help minimize the
overshoot and to decrease steady state error more quickly.
BUG=b:174167890
BRANCH=dedede
TEST=Build and flash drawlat; verify that at low SOC, charging from
the sub board results in lower overshoot and reduced time to correct
steady state error.
TEST=Cutoff battery, verify that battery is able to be revived from
sub board.
TEST=Verify DUT can still boot off of AC only.
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: Id15c226f9ac7bf85f4b427348640419565253d45
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2567036
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Diffstat (limited to 'board/drawcia')
| -rw-r--r-- | board/drawcia/board.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/board/drawcia/board.c b/board/drawcia/board.c index b7fb48ff62..5102a01428 100644 --- a/board/drawcia/board.c +++ b/board/drawcia/board.c @@ -656,10 +656,10 @@ __override void ocpc_get_pid_constants(int *kp, int *kp_div, int *kd, int *kd_div) { *kp = 3; - *kp_div = 14; + *kp_div = 20; *ki = 3; - *ki_div = 500; + *ki_div = 125; *kd = 4; *kd_div = 40; |