diff options
| author | Scott Chao <scott_chao@wistron.corp-partner.google.com> | 2020-10-28 08:02:25 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-10-30 18:48:46 +0000 |
| commit | 194ac0008facaf4245d364c844e78f8fcd53b742 (patch) | |
| tree | f426d53c571d42650cf6fc0f47ca7244ea69a039 /board/eldrid | |
| parent | bd27fb95ed9857a97e4554bdda4a983c311ee8e9 (diff) | |
| download | chrome-ec-194ac0008facaf4245d364c844e78f8fcd53b742.tar.gz | |
eldrid: disable CONFIG_KEYBOARD_VIVALDI
Disable Vivaldi keyboard since Vivaldi currently does not
allow for side volume buttons to be distinguished from
keyboard volume F9/F10 keys. This is necessary so that Chrome
can ignore F9/F10 in tablet mode, but side volume buttons still work.
BUG=b:171815391
BRANCH=volteer
TEST=make -j BOARD=eldrid
TEST=make buildall
TEST=test on eldrid, side-buttons work in clamshell/tablet mode
and that F9/F10 only work in clamshell.
Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Change-Id: I168521d80e1ff1e4103485a8c25c440cb5b08ce9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2503749
Reviewed-by: Keith Short <keithshort@chromium.org>
Diffstat (limited to 'board/eldrid')
| -rw-r--r-- | board/eldrid/board.h | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/board/eldrid/board.h b/board/eldrid/board.h index 537ab2cf36..ca5b47749f 100644 --- a/board/eldrid/board.h +++ b/board/eldrid/board.h @@ -30,6 +30,13 @@ /* Keyboard features */ +/* + * Disable VOL up/down when tablet mode. + * TODO(b/170966461): Re-enable Vivaldi keyboard once + * 8042 and MKBP drivers can coexist. + */ +#undef CONFIG_KEYBOARD_VIVALDI + /* Sensors */ /* BMA253 accelerometer in base */ #define CONFIG_ACCEL_BMA255 |