summaryrefslogtreecommitdiff
path: root/board/elemi
diff options
context:
space:
mode:
authorDevin Lu <Devin.Lu@quantatw.com>2020-11-12 20:40:40 +0800
committerCommit Bot <commit-bot@chromium.org>2020-11-16 23:28:30 +0000
commitfb11cd57e3a49d164264f72790d51f4e9b4a8993 (patch)
tree9fb203b55e0a99f3f65ccf54055d7636ce128f73 /board/elemi
parentaf33a4479d3e42248db4716e7c3a08198e4bd216 (diff)
downloadchrome-ec-fb11cd57e3a49d164264f72790d51f4e9b4a8993.tar.gz
elemi: Remove unused daughterboard configuration
This patch remove unused daughterboard configuration since Elemi only support USB3 active doughterboard. BUG=b:173033778 BRANCH=firmware-volteer-13521.B-master TEST=Make sure daughterboard C1 port still works. Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: I1fd856488652aa0be8d4f1ed171609c0fcfedf8d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2534438 Reviewed-by: Keith Short <keithshort@chromium.org>
Diffstat (limited to 'board/elemi')
-rw-r--r--board/elemi/board.c196
-rw-r--r--board/elemi/board.h11
2 files changed, 20 insertions, 187 deletions
diff --git a/board/elemi/board.c b/board/elemi/board.c
index b50a141496..4f9db697e2 100644
--- a/board/elemi/board.c
+++ b/board/elemi/board.c
@@ -4,7 +4,6 @@
*/
/* Elemi board-specific configuration */
-#include "bb_retimer.h"
#include "button.h"
#include "common.h"
#include "accelgyro.h"
@@ -15,7 +14,6 @@
#include "driver/bc12/pi3usb9201.h"
#include "driver/ppc/sn5s330.h"
#include "driver/ppc/syv682x.h"
-#include "driver/retimer/bb_retimer.h"
#include "driver/sync.h"
#include "driver/tcpm/ps8xxx.h"
#include "driver/tcpm/rt1715.h"
@@ -68,54 +66,12 @@ struct keyboard_scan_config keyscan_config = {
/******************************************************************************/
/*
- * FW_CONFIG defaults for Volteer if the CBI data is not initialized.
+ * FW_CONFIG defaults for Elemi if the CBI data is not initialized.
*/
union volteer_cbi_fw_config fw_config_defaults = {
- .usb_db = DB_USB4_GEN2,
+ .usb_db = DB_USB3_ACTIVE,
};
-__override enum tbt_compat_cable_speed board_get_max_tbt_speed(int port)
-{
- enum ec_cfg_usb_db_type usb_db = ec_cfg_usb_db_type();
-
- if (port == USBC_PORT_C1) {
- if (usb_db == DB_USB4_GEN2) {
- /*
- * Older boards violate 205mm trace length prior
- * to connection to the re-timer and only support up
- * to GEN2 speeds.
- */
- return TBT_SS_U32_GEN1_GEN2;
- } else if (usb_db == DB_USB4_GEN3) {
- return TBT_SS_TBT_GEN3;
- }
- }
-
- /*
- * Thunderbolt-compatible mode not supported
- *
- * TODO (b/147726366): All the USB-C ports need to support same speed.
- * Need to fix once USB-C feature set is known for Volteer.
- */
- return TBT_SS_RES_0;
-}
-
-__override bool board_is_tbt_usb4_port(int port)
-{
- enum ec_cfg_usb_db_type usb_db = ec_cfg_usb_db_type();
-
- /*
- * Volteer reference design only supports TBT & USB4 on port 1
- * if the USB4 DB is present.
- *
- * TODO (b/147732807): All the USB-C ports need to support same
- * features. Need to fix once USB-C feature set is known for Volteer.
- */
- return ((port == USBC_PORT_C1)
- && ((usb_db == DB_USB4_GEN2) || (usb_db == DB_USB4_GEN3)));
-}
-
-/******************************************************************************/
/* Physical fans. These are logically separate from pwm_channels. */
const struct fan_conf fan_conf_0 = {
@@ -290,20 +246,6 @@ static void kb_backlight_disable(void)
}
DECLARE_HOOK(HOOK_CHIPSET_SUSPEND, kb_backlight_disable, HOOK_PRIO_DEFAULT);
-/******************************************************************************/
-/* Volteer specific USB daughter-board configuration */
-
-/* USBC TCPC configuration for USB3 daughter board */
-static const struct tcpc_config_t tcpc_config_p1_usb3 = {
- .bus_type = EC_BUS_TYPE_I2C,
- .i2c_info = {
- .port = I2C_PORT_USB_C1,
- .addr_flags = PS8751_I2C_ADDR1_FLAGS,
- },
- .flags = TCPC_FLAGS_TCPCI_REV2_0 | TCPC_FLAGS_TCPCI_REV2_0_NO_VSAFE0V,
- .drv = &ps8xxx_tcpm_drv,
-};
-
/*
* USB3 DB mux configuration - the top level mux still needs to be set to the
* virtual_usb_mux_driver so the AP gets notified of mux changes and updates
@@ -316,19 +258,6 @@ static const struct usb_mux usbc1_usb3_db_retimer = {
.next_mux = NULL,
};
-static const struct usb_mux mux_config_p1_usb3_active = {
- .usb_port = USBC_PORT_C1,
- .driver = &virtual_usb_mux_driver,
- .hpd_update = &virtual_hpd_update,
- .next_mux = &usbc1_usb3_db_retimer,
-};
-
-static const struct usb_mux mux_config_p1_usb3_passive = {
- .usb_port = USBC_PORT_C1,
- .driver = &virtual_usb_mux_driver,
- .hpd_update = &virtual_hpd_update,
-};
-
/******************************************************************************/
/* USB-A charging control */
@@ -368,98 +297,14 @@ static void ps8815_reset(void)
void board_reset_pd_mcu(void)
{
- enum ec_cfg_usb_db_type usb_db = ec_cfg_usb_db_type();
-
/* No reset available for TCPC on port 0 */
/* Daughterboard specific reset for port 1 */
- if (usb_db == DB_USB3_ACTIVE) {
- ps8815_reset();
- usb_mux_hpd_update(USBC_PORT_C1, 0, 0);
- }
+ ps8815_reset();
+ usb_mux_hpd_update(USBC_PORT_C1, 0, 0);
}
-/*
- * Set up support for the USB3 daughterboard:
- * Parade PS8815 TCPC (integrated retimer)
- * Diodes PI3USB9201 BC 1.2 chip (same as USB4 board)
- * Silergy SYV682A PPC (same as USB4 board)
- * Virtual mux with stacked retimer
- */
-static void config_db_usb3_active(void)
-{
- tcpc_config[USBC_PORT_C1] = tcpc_config_p1_usb3;
- usb_muxes[USBC_PORT_C1] = mux_config_p1_usb3_active;
-}
-
-/*
- * Set up support for the passive USB3 daughterboard:
- * TUSB422 TCPC (already the default)
- * PI3USB9201 BC 1.2 chip (already the default)
- * Silergy SYV682A PPC (already the default)
- * Virtual mux without stacked retimer
- */
-
-static void config_db_usb3_passive(void)
-{
- usb_muxes[USBC_PORT_C1] = mux_config_p1_usb3_passive;
-}
-
-static void config_port_discrete_tcpc(int port)
-{
- /*
- * Support 2 Pin-to-Pin compatible parts: TUSB422 and RT1715, for
- * simplicity allow either and decide at runtime which we are using.
- * Default to TUSB422, and switch to RT1715 if it is on the I2C bus and
- * the VID matches.
- */
-
- int regval;
-
- if (i2c_read16(port ? I2C_PORT_USB_C1 : I2C_PORT_USB_C0,
- RT1715_I2C_ADDR_FLAGS, TCPC_REG_VENDOR_ID,
- &regval) == EC_SUCCESS) {
- if (regval == RT1715_VENDOR_ID) {
- CPRINTS("C%d: RT1715 detected", port);
- tcpc_config[port].i2c_info.addr_flags =
- RT1715_I2C_ADDR_FLAGS;
- tcpc_config[port].drv = &rt1715_tcpm_drv;
- return;
- }
- }
- CPRINTS("C%d: Default to TUSB422", port);
-}
-
-static const char *db_type_prefix = "USB DB type: ";
__override void board_cbi_init(void)
{
- enum ec_cfg_usb_db_type usb_db = ec_cfg_usb_db_type();
-
- config_port_discrete_tcpc(0);
- switch (usb_db) {
- case DB_USB_ABSENT:
- CPRINTS("%sNone", db_type_prefix);
- break;
- case DB_USB4_GEN2:
- config_port_discrete_tcpc(1);
- CPRINTS("%sUSB4 Gen1/2", db_type_prefix);
- break;
- case DB_USB4_GEN3:
- config_port_discrete_tcpc(1);
- CPRINTS("%sUSB4 Gen3", db_type_prefix);
- break;
- case DB_USB3_ACTIVE:
- config_db_usb3_active();
- CPRINTS("%sUSB3 Active", db_type_prefix);
- break;
- case DB_USB3_PASSIVE:
- config_db_usb3_passive();
- config_port_discrete_tcpc(1);
- CPRINTS("%sUSB3 Passive", db_type_prefix);
- break;
- default:
- CPRINTS("%sID %d not supported", db_type_prefix, usb_db);
- }
-
if ((!IS_ENABLED(TEST_BUILD) && !ec_cfg_has_numeric_pad()) ||
get_board_id() <= 2)
keyboard_raw_set_cols(KEYBOARD_COLS_NO_KEYPAD);
@@ -513,22 +358,24 @@ BUILD_ASSERT(ARRAY_SIZE(pi3usb9201_bc12_chips) == USBC_PORT_COUNT);
/******************************************************************************/
/* USBC TCPC configuration */
-struct tcpc_config_t tcpc_config[] = {
+const struct tcpc_config_t tcpc_config[] = {
[USBC_PORT_C0] = {
.bus_type = EC_BUS_TYPE_I2C,
.i2c_info = {
.port = I2C_PORT_USB_C0,
- .addr_flags = TUSB422_I2C_ADDR_FLAGS,
+ .addr_flags = RT1715_I2C_ADDR_FLAGS,
},
- .drv = &tusb422_tcpm_drv,
+ .drv = &rt1715_tcpm_drv,
},
[USBC_PORT_C1] = {
.bus_type = EC_BUS_TYPE_I2C,
.i2c_info = {
.port = I2C_PORT_USB_C1,
- .addr_flags = TUSB422_I2C_ADDR_FLAGS,
+ .addr_flags = PS8751_I2C_ADDR1_FLAGS,
},
- .drv = &tusb422_tcpm_drv,
+ .flags = TCPC_FLAGS_TCPCI_REV2_0 |
+ TCPC_FLAGS_TCPCI_REV2_0_NO_VSAFE0V,
+ .drv = &ps8xxx_tcpm_drv,
},
};
BUILD_ASSERT(ARRAY_SIZE(tcpc_config) == USBC_PORT_COUNT);
@@ -536,13 +383,7 @@ BUILD_ASSERT(CONFIG_USB_PD_PORT_MAX_COUNT == USBC_PORT_COUNT);
/******************************************************************************/
/* USBC mux configuration - Tiger Lake includes internal mux */
-struct usb_mux usbc1_usb4_db_retimer = {
- .usb_port = USBC_PORT_C1,
- .driver = &bb_usb_retimer,
- .i2c_port = I2C_PORT_USB_1_MIX,
- .i2c_addr_flags = USBC_PORT_C1_BB_RETIMER_I2C_ADDR,
-};
-struct usb_mux usb_muxes[] = {
+const struct usb_mux usb_muxes[] = {
[USBC_PORT_C0] = {
.usb_port = USBC_PORT_C0,
.driver = &virtual_usb_mux_driver,
@@ -552,22 +393,11 @@ struct usb_mux usb_muxes[] = {
.usb_port = USBC_PORT_C1,
.driver = &virtual_usb_mux_driver,
.hpd_update = &virtual_hpd_update,
- .next_mux = &usbc1_usb4_db_retimer,
+ .next_mux = &usbc1_usb3_db_retimer,
},
};
BUILD_ASSERT(ARRAY_SIZE(usb_muxes) == USBC_PORT_COUNT);
-struct bb_usb_control bb_controls[] = {
- [USBC_PORT_C0] = {
- /* USB-C port 0 doesn't have a retimer */
- },
- [USBC_PORT_C1] = {
- .usb_ls_en_gpio = GPIO_USB_C1_LS_EN,
- .retimer_rst_gpio = GPIO_USB_C1_RT_RST_ODL,
- },
-};
-BUILD_ASSERT(ARRAY_SIZE(bb_controls) == USBC_PORT_COUNT);
-
static void board_tcpc_init(void)
{
/* Don't reset TCPCs after initial reset */
diff --git a/board/elemi/board.h b/board/elemi/board.h
index 313c450e7a..46d9c83b22 100644
--- a/board/elemi/board.h
+++ b/board/elemi/board.h
@@ -71,10 +71,6 @@
/* Enabling Thunderbolt-compatible mode */
#define CONFIG_USB_PD_TBT_COMPAT_MODE
-/* Enabling USB4 mode */
-#define CONFIG_USB_PD_USB4
-#define USBC_PORT_C1_BB_RETIMER_I2C_ADDR 0x40
-
/* USB Type A Features */
#define USB_PORT_COUNT 1
#define CONFIG_USB_PORT_POWER_DUMB
@@ -82,6 +78,9 @@
/* USBC PPC*/
#define CONFIG_USBC_PPC_SN5S330 /* USBC port C0 */
#define CONFIG_USBC_PPC_SYV682X /* USBC port C1 */
+#undef CONFIG_USB_PD_TCPC_RUNTIME_CONFIG
+#undef CONFIG_USB_PD_TCPM_TUSB422
+#undef CONFIG_USB_MUX_RUNTIME_CONFIG
/* BC 1.2 */
@@ -93,6 +92,10 @@
#define CONFIG_CHARGER_SENSE_RESISTOR 10
#define CONFIG_CHARGER_SENSE_RESISTOR_AC 10
+/* Retimer */
+#undef CONFIG_USBC_RETIMER_INTEL_BB
+#undef CONFIG_USBC_RETIMER_INTEL_BB_RUNTIME_CONFIG
+
/*
* Macros for GPIO signals used in common code that don't match the
* schematic names. Signal names in gpio.inc match the schematic and are