diff options
| author | Hung-Te Lin <hungte@chromium.org> | 2018-08-08 08:55:38 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-08-15 20:36:15 -0700 |
| commit | 43899e1d9e3f523701d8d8b5c93890322894e6e4 (patch) | |
| tree | e1064e69d6b8bbf91e050c34251a77ba3ce959e2 /board/eve | |
| parent | 0c94bad3ebecb4f33544ffb3b136746d044c4ea9 (diff) | |
| download | chrome-ec-43899e1d9e3f523701d8d8b5c93890322894e6e4.tar.gz | |
keyboard: Keep only scan code set 2 table and do translation for set 1.
The 8042 scan code set 1 can be directly translated from set 2, with a
256 byte table. With this change, we can always process key stroke in
scan code (set 2), and only translate in the single function
`scancode_bytes`. This is very helpful when we need to do key
processing, for example the buttons_8042 can now be simplified with only
one scan code. And is extremely helpful if we want to do dynamic
translation (i.e., to prevent something like CL:1164725).
For `make BOARD=samus', the free space is also increased from 18472 to
18656 (+184) bytes.
BUG=None
TEST=make buildall; manually installed on Eve and tested by
running 'keyboard' factory test to make sure all key scancodes
are not changed.
BRANCH=None
Change-Id: Ieb303d84edcd4375bbeb1ea5f032d0462bbfd250
Signed-off-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1166742
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'board/eve')
| -rw-r--r-- | board/eve/board.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/board/eve/board.c b/board/eve/board.c index 1ab87d7d9d..30089a3321 100644 --- a/board/eve/board.c +++ b/board/eve/board.c @@ -489,7 +489,6 @@ static void board_init(void) if (board_get_version() == 4) { /* Set F13 to new defined key on EVT */ CPRINTS("Overriding F13 scan code"); - scancode_set1[3][9] = 0xe058; scancode_set2[3][9] = 0xe007; } #endif |