diff options
| author | Edward Hill <ecgh@chromium.org> | 2020-04-15 21:23:09 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-04-20 04:32:35 +0000 |
| commit | bed6cac7b4d68c4315f5426b741a6ee508e459c6 (patch) | |
| tree | 7d34136323ab4b5d40e7adfbfef53c0ceaba84d1 /board/ezkinil/board.c | |
| parent | 7cb1943254892e33d5ce55d9835e723824de85b5 (diff) | |
| download | chrome-ec-bed6cac7b4d68c4315f5426b741a6ee508e459c6.tar.gz | |
PS8743: Clean up mode reg bit names
Align names for PS8743_REG_MODE with similar PS8802_REG2_MODE.
BUG=b:152736880
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I8b8ebe41eb2bffad14cee8347549447d5583da47
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2151791
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Diffstat (limited to 'board/ezkinil/board.c')
| -rw-r--r-- | board/ezkinil/board.c | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/board/ezkinil/board.c b/board/ezkinil/board.c index 8859701416..5ff02886fd 100644 --- a/board/ezkinil/board.c +++ b/board/ezkinil/board.c @@ -276,15 +276,11 @@ static int board_ps8743_mux_set(const struct usb_mux *me, rv = ps8743_read(me, PS8743_REG_MODE, ®); if (rv) return rv; - /* - * TODO(b:152736880) Due to Ezkinil doesn't have FLIP_PIN and - * CE_DP_PIN, we need set 1 to this two BIT, but the name of - * these two bits are confusing. Need fix the name in other patch. - */ - /* Disable FLIP pin detect since ezkinil don't have FLIP. */ - reg |= PS8743_MODE_FLIP_PIN_ENABLED; - /* Disable CE_DP pin detect, since ezkinil don't have CE_DP. */ - reg |= PS8743_MODE_CE_DP_ENABLED; + + /* Disable FLIP pin, enable I2C control. */ + reg |= PS8743_MODE_FLIP_REG_CONTROL; + /* Disable CE_DP pin, enable I2C control. */ + reg |= PS8743_MODE_DP_REG_CONTROL; /* DP specific config */ if (mux_state & USB_PD_MUX_DP_ENABLED) { |