diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2019-04-26 10:33:51 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-04-29 20:57:08 -0700 |
| commit | 961c0d0fdc9cb981467ea1df9847032b1b770c74 (patch) | |
| tree | e22cc968e1f9b94b9063a4457285d7181fab3f4b /board/flapjack | |
| parent | 4750cd2422146f536ac420401822d3a38a0a9e6a (diff) | |
| download | chrome-ec-961c0d0fdc9cb981467ea1df9847032b1b770c74.tar.gz | |
Flapjack: Fix bit size for LCM_ID
LCM_ID's bit size is 4. Thus, PANEL_UNINITIALIZED should be 0xf.
This fixes 'bitwise comparison always evaluates to false' error.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Cq-Depend: chromium:1586582
BUG=none
BRANCH=none
TEST=make BOARD=flapjack
Change-Id: Ib9c43cb7b929f902cdced627e1d40669ae365775
Reviewed-on: https://chromium-review.googlesource.com/1585398
Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'board/flapjack')
| -rw-r--r-- | board/flapjack/board.c | 1 | ||||
| -rw-r--r-- | board/flapjack/board.h | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/board/flapjack/board.c b/board/flapjack/board.c index 46b2d584d7..843045b3d3 100644 --- a/board/flapjack/board.c +++ b/board/flapjack/board.c @@ -61,6 +61,7 @@ static const struct mv_to_id panels[] = { { PANEL_BOE_HIMAX8279D8P, 280 }, }; BUILD_ASSERT(ARRAY_SIZE(panels) < PANEL_COUNT); +BUILD_ASSERT(PANEL_COUNT <= PANEL_UNINITIALIZED); uint16_t board_version; uint8_t oem; diff --git a/board/flapjack/board.h b/board/flapjack/board.h index 11485a3eb3..0235dc1a29 100644 --- a/board/flapjack/board.h +++ b/board/flapjack/board.h @@ -262,7 +262,7 @@ enum panel_id { PANEL_BOE_HIMAX8279D10P, PANEL_BOE_HIMAX8279D8P, PANEL_COUNT, - PANEL_UNINITIALIZED = 0xff, + PANEL_UNINITIALIZED = 0xf, }; /* power signal definitions */ |