diff options
author | Wai-Hong Tam <waihong@google.com> | 2021-08-03 17:17:56 -0700 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2021-08-05 00:13:33 +0000 |
commit | 2eb53a39662b905c65015bafb5f73ab2324d369c (patch) | |
tree | 6352433557cdb05c75b1eef449c9ecf844bfc3d0 /board/gimble/sensors.c | |
parent | fc016f2dce16d0555deee69e00ea5a626eb27f21 (diff) | |
download | chrome-ec-2eb53a39662b905c65015bafb5f73ab2324d369c.tar.gz |
lid_angle: Create a common callback for lid angle changes
Each board defines its own callback lid_angle_peripheral_enable().
The implementation is very similar. Create a common implementation
and reduce the duplicated code.
This CL removes the board callbacks which are identifical to the
common callback. If it is slightly different, keep it and add
the __override tag.
The check of TEST_BUILD is unnecessary as the board callback is not
linked in the test build.
BRANCH=None
BUG=b:194922043
TEST=Build all the images.
Change-Id: I73d381730f35b80eff69399cdfc5fb54f839aee0
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3069175
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'board/gimble/sensors.c')
-rw-r--r-- | board/gimble/sensors.c | 19 |
1 files changed, 0 insertions, 19 deletions
diff --git a/board/gimble/sensors.c b/board/gimble/sensors.c index 2931e68d31..500cd580d6 100644 --- a/board/gimble/sensors.c +++ b/board/gimble/sensors.c @@ -222,22 +222,3 @@ struct ec_thermal_config thermal_params[] = { [TEMP_SENSOR_3_CHARGER] = thermal_inductor, }; BUILD_ASSERT(ARRAY_SIZE(thermal_params) == TEMP_SENSOR_COUNT); - -#ifndef TEST_BUILD -void lid_angle_peripheral_enable(int enable) -{ - int chipset_in_s0 = chipset_in_state(CHIPSET_STATE_ON); - - if (enable) { - keyboard_scan_enable(1, KB_SCAN_DISABLE_LID_ANGLE); - } else { - /* - * Ensure that the chipset is off before disabling the keyboard. - * When the chipset is on, the EC keeps the keyboard enabled and - * the AP decides whether to ignore input devices or not. - */ - if (!chipset_in_s0) - keyboard_scan_enable(0, KB_SCAN_DISABLE_LID_ANGLE); - } -} -#endif |