diff options
| author | Edward Hill <ecgh@chromium.org> | 2018-04-26 15:14:50 -0600 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-04-27 12:22:52 -0700 |
| commit | d786f8285bd860e24fbf6bab2e1ac936836e3743 (patch) | |
| tree | bf566647360c57904acfcf20314b7e89da59f87d /board/grunt | |
| parent | 487c7a98cf73afdddeef2b63de2fe09320a140f0 (diff) | |
| download | chrome-ec-d786f8285bd860e24fbf6bab2e1ac936836e3743.tar.gz | |
grunt: Increase CONFIG_EXTPOWER_DEBOUNCE_MS to 200
When plugging in USB-C power with no battery (or cutoff battery),
the ACOK signal from the ISL9238 charger sometimes has a negative
pulse of up to 175 ms after VBUS increases from 5V to 20V.
The width of the pulse varies from board to board.
Increase CONFIG_EXTPOWER_DEBOUNCE_MS to 200 ms (from default of 30)
to ignore this negative pulse.
If we think we are running with no battery and no AC then we will
set the charger voltage to 2.048V, and therefore lose power.
BUG=b:77455171
BRANCH=none
TEST=Plug power into Grunt with no battery.
Change-Id: I9c0f358985e4c630daef93d61c49b87c2e11a480
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1031563
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'board/grunt')
| -rw-r--r-- | board/grunt/board.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/board/grunt/board.h b/board/grunt/board.h index 0e6123ab74..dd6d3c7886 100644 --- a/board/grunt/board.h +++ b/board/grunt/board.h @@ -73,6 +73,12 @@ #define CONFIG_CHIPSET_STONEY #define CONFIG_CHIPSET_RESET_HOOK +/* + * ACOK from ISL9238 sometimes has a negative pulse after connecting + * USB-C power. We want to ignore it. b/77455171 + */ +#undef CONFIG_EXTPOWER_DEBOUNCE_MS +#define CONFIG_EXTPOWER_DEBOUNCE_MS 200 #define CONFIG_EXTPOWER_GPIO #define CONFIG_POWER_COMMON #define CONFIG_POWER_SHUTDOWN_PAUSE_IN_S5 |