diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2016-02-25 10:48:10 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-02-25 18:25:37 -0800 |
| commit | 5a9a8f3dbf93cb651bef6ffbd420a24ca5ee01aa (patch) | |
| tree | aa3ab4c3d1df46023986975ff757d5135c5c4163 /board/hadoken/gpio.inc | |
| parent | 8376cf5ccae5462287c806cd9b2cb859b5f8f806 (diff) | |
| download | chrome-ec-5a9a8f3dbf93cb651bef6ffbd420a24ca5ee01aa.tar.gz | |
cleanup: Add warning comment to gpio.inc files
With commit e9883124ff16, a GPIO_INT macro was added. That change
also required that all instances of GPIO_INT in a board's
gpio.inc file come before any GPIO macros, or the interrupt
handler wouldn't work properly.
This CL just adds a warning comment about requirement to all
gpio.inc files.
BUG=chromium:471331
BRANCH=none
TEST=make buildall, test image on Cr50
This is a change to comments only. There is no new behavior to
verify, although I did run try out one new image just to be sure
nothing stupid happened.
Change-Id: I83f7819929a53bce3a8bae04d15b3ee3bda11738
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/329334
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Diffstat (limited to 'board/hadoken/gpio.inc')
| -rw-r--r-- | board/hadoken/gpio.inc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/board/hadoken/gpio.inc b/board/hadoken/gpio.inc index eb8be3d3f4..33e6ab6a7a 100644 --- a/board/hadoken/gpio.inc +++ b/board/hadoken/gpio.inc @@ -5,11 +5,12 @@ * found in the LICENSE file. */ +/* Declare symbolic names for all the GPIOs that we care about. + * Note: Those with interrupt handlers must be declared first. */ + #define GPIO_KB_INPUT (GPIO_INPUT | GPIO_PULL_UP | GPIO_INT_BOTH) #define GPIO_KB_OUTPUT GPIO_ODR_HIGH -/* Inputs with interrupt handlers are first for efficiency */ - /* Keyboard inputs */ /* * TODO(yjlou): call keyboard_raw_gpio_interrupt() in chip/nrf51/keyboard_raw.c |