diff options
| author | Scott Collyer <scollyer@google.com> | 2019-02-12 13:28:23 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-02-13 14:42:43 -0800 |
| commit | 136622432dab14e8d939773a1ac556f941305a1b (patch) | |
| tree | b16307b189226f4034491c1c641ebdb3234cdf85 /board/hatch | |
| parent | 232c261f933c51418fffbe4db0ea0921288fbc09 (diff) | |
| download | chrome-ec-136622432dab14e8d939773a1ac556f941305a1b.tar.gz | |
hatch: Adjust temperature threshold when fan is under EC control
Currently the fan is being controlled by EC, not DPTF. The default
settings for temperature were taken from Nami, but not adjusted for
Hatch. This CL reduces the temperature for fan being used to 25C. This
results in the fan being turned on a lower temperature and will
hopefully help prevent thermal related AP shutdowns.
BUG=b:124316213
BRANCH=none
TEST=Verfied that when temperature reading was > 25 degrees the fan
turned on and that its on duty cycle decreased from there as the
temperature reading decreased until the temp reading was < 25C and the
fan turned off.
Change-Id: I31025585467b2d0bd87040c034f8a59966a1dd20
Signed-off-by: Scott Collyer <scollyer@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1467968
Commit-Ready: Scott Collyer <scollyer@chromium.org>
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Diffstat (limited to 'board/hatch')
| -rw-r--r-- | board/hatch/board.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/board/hatch/board.c b/board/hatch/board.c index e6cf4dfafa..21ff639892 100644 --- a/board/hatch/board.c +++ b/board/hatch/board.c @@ -143,7 +143,12 @@ const struct temp_sensor_t temp_sensors[] = { BUILD_ASSERT(ARRAY_SIZE(temp_sensors) == TEMP_SENSOR_COUNT); -/* Nami/Vayne Remote 1, 2 */ +/* Hatch Temperature sensors */ +/* + * TODO(b/124316213): These setting need to be reviewed and set appropriately + * for Hatch. They matter when the EC is controlling the fan as opposed to DPTF + * control. + */ const static struct ec_thermal_config thermal_a = { .temp_host = { [EC_TEMP_THRESH_WARN] = 0, @@ -155,7 +160,7 @@ const static struct ec_thermal_config thermal_a = { [EC_TEMP_THRESH_HIGH] = C_TO_K(65), [EC_TEMP_THRESH_HALT] = 0, }, - .temp_fan_off = C_TO_K(39), + .temp_fan_off = C_TO_K(25), .temp_fan_max = C_TO_K(50), }; |