diff options
author | Hsu Wei-Cheng <mojahsu@chromium.org> | 2021-08-06 08:32:44 +0000 |
---|---|---|
committer | Hsu Wei-Cheng <mojahsu@chromium.org> | 2021-08-06 09:21:55 +0000 |
commit | 53c02958d338f8a4eabd2e5239800d1e7fbac60f (patch) | |
tree | ef49313fb86cf79cca0639ae317718f56309d104 /board/hatch_fp/board_rw.h | |
parent | c0121aadfa214f124f20e50c9fe2552f09d77dd1 (diff) | |
download | chrome-ec-53c02958d338f8a4eabd2e5239800d1e7fbac60f.tar.gz |
Revert "bloonchipper: Reintroduce sleep lines to RO"
This reverts commit 5e2a0808b7dfc736676daf8ba4d6cf683076d961.
Reason for revert: It may broke CQ
BUG=b:195718112
Original change's description:
> bloonchipper: Reintroduce sleep lines to RO
>
> Change https://crrev.com/c/2673909 removed the sleep lines from RO
> in an effort to minimize the RO complexity.
> Most notably, this isolated the deep-sleep/low-power-idle
> logic to RW only.
>
> Unfortunately, the sleep lines also control whether the SPI host interface
> is listening, which allows it to ignore spurious communication.
>
> It seems safer to reinstate the the sleep line with low power idle
> active and directly disable CONFIG_LOW_POWER_IDLE in subsequent CL.
>
> We reinstate the sleep line gpio logic from the following:
> https://crrev.com/c5545464431669029f42829d542fa491d767ee5f/board/hatch_fp/board.c
> This is the parent commit to the CL that refactors the sleep lines.
>
> BRANCH=none
> BUG=b:178746753
> TEST=# Connect servo_micro to a dragonclaw board.
> make proj-bloonchipper -j
> sudo servod --board=dragonclaw
> ./util/flash_ec --board=bloonchipper
>
> dut-control fpmcu_slp:off fpmcu_slp_alt:off
> dut-control pp3300_dx_mcu_mw # Should be around 20mw
> dut-control fpmcu_slp:on fpmcu_slp_alt:off
> dut-control pp3300_dx_mcu_mw # Should be less the 5mw
> dut-control fpmcu_slp:off fpmcu_slp_alt:on
> dut-control pp3300_dx_mcu_mw # Should be less the 5mw
> dut-control fpmcu_slp:on fpmcu_slp_alt:on
> dut-control pp3300_dx_mcu_mw # Should be less the 5mw
> dut-control fpmcu_slp:off fpmcu_slp_alt:off
>
> minicom -D$(dut-control -o raw_fpmcu_console_uart_pty)
> > reboot ro
> # Ctrl-A Q
>
> dut-control fpmcu_slp:off fpmcu_slp_alt:off
> dut-control pp3300_dx_mcu_mw # Should be around 20mw
> dut-control fpmcu_slp:on fpmcu_slp_alt:off
> dut-control pp3300_dx_mcu_mw # Should be less the 5mw
> dut-control fpmcu_slp:off fpmcu_slp_alt:on
> dut-control pp3300_dx_mcu_mw # Should be less the 5mw
> dut-control fpmcu_slp:on fpmcu_slp_alt:on
> dut-control pp3300_dx_mcu_mw # Should be less the 5mw
> dut-control fpmcu_slp:off fpmcu_slp_alt:off
>
> minicom -D$(dut-control -o raw_fpmcu_console_uart_pty)
> > reboot
> > fpenroll
> > fpmatch
> > reboot
> # Ctrl-A Q
>
> Signed-off-by: Craig Hesling <hesling@chromium.org>
> Change-Id: I503cb3b62740300b265a4ddb165e29d9e36727fd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3012241
> Commit-Queue: Josie Nordrum <josienordrum@google.com>
> Reviewed-by: Josie Nordrum <josienordrum@google.com>
Bug: b:178746753
Change-Id: If610fdffaef778f26c712bbad360e84651df61bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3077589
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Hsu Wei-Cheng <mojahsu@chromium.org>
Auto-Submit: Hsu Wei-Cheng <mojahsu@chromium.org>
Diffstat (limited to 'board/hatch_fp/board_rw.h')
-rw-r--r-- | board/hatch_fp/board_rw.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/board/hatch_fp/board_rw.h b/board/hatch_fp/board_rw.h index 1bee6c947d..bcfa061b25 100644 --- a/board/hatch_fp/board_rw.h +++ b/board/hatch_fp/board_rw.h @@ -7,6 +7,7 @@ #define __CROS_EC_BOARD_HATCH_FP_BOARD_RW_H void fps_event(enum gpio_signal signal); +void slp_event(enum gpio_signal signal); void board_init_rw(void); |