diff options
| author | Tom Hughes <tomhughes@chromium.org> | 2021-02-03 10:41:36 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-02-12 19:00:14 +0000 |
| commit | c8ebbe6b954f9d8e00d78a07e32ff95ffc4516a6 (patch) | |
| tree | 1e0108e6cae1c10a29fff380847dc90d3dba4b39 /board/hatch_fp/fpsensor_detect.c | |
| parent | c5545464431669029f42829d542fa491d767ee5f (diff) | |
| download | chrome-ec-c8ebbe6b954f9d8e00d78a07e32ff95ffc4516a6.tar.gz | |
bloonchipper: Refactor GPIOs to keep RO minimal
We want the amount of code and number of things defined in RO to be as
minimal as possible since RO is frozen forever. By keeping RO minimal,
we can reduce surface area for attacks and also confusion when GPIOs are
removed or renamed.
The fingerprint-related code only runs in RW, so move all
fingerprint-related GPIOs and associated code into separate files that
are only included in RW.
BRANCH=none
BUG=b:178746753
TEST=On dragonclaw v0.2 with servo micro and jtrace, verify sensor ID
shows on console
TEST=On dragonair, test fingerprint enroll and unlock
TEST=On morphius, test fingerprint enroll and unlock
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Ia6791666b57ed9be81230d8a5f77d874f56da5a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2673909
Reviewed-by: Craig Hesling <hesling@chromium.org>
Diffstat (limited to 'board/hatch_fp/fpsensor_detect.c')
| -rw-r--r-- | board/hatch_fp/fpsensor_detect.c | 26 |
1 files changed, 0 insertions, 26 deletions
diff --git a/board/hatch_fp/fpsensor_detect.c b/board/hatch_fp/fpsensor_detect.c index 86071bd7f6..638b5fbfe0 100644 --- a/board/hatch_fp/fpsensor_detect.c +++ b/board/hatch_fp/fpsensor_detect.c @@ -7,27 +7,6 @@ #include "gpio.h" #include "timer.h" -enum fp_sensor_type get_fp_sensor_type(void) -{ - enum fp_sensor_type ret; - - gpio_set_level(GPIO_DIVIDER_HIGHSIDE, 1); - usleep(1); - switch (gpio_get_level(GPIO_FP_SENSOR_SEL)) { - case 0: - ret = FP_SENSOR_TYPE_ELAN; - break; - case 1: - ret = FP_SENSOR_TYPE_FPC; - break; - default: - ret = FP_SENSOR_TYPE_UNKNOWN; - break; - } - gpio_set_level(GPIO_DIVIDER_HIGHSIDE, 0); - return ret; -} - enum fp_transport_type get_fp_transport_type(void) { enum fp_transport_type ret; @@ -48,8 +27,3 @@ enum fp_transport_type get_fp_transport_type(void) gpio_set_level(GPIO_DIVIDER_HIGHSIDE, 0); return ret; } - -enum fp_sensor_spi_select get_fp_sensor_spi_select(void) -{ - return FP_SENSOR_SPI_SELECT_PRODUCTION; -} |