diff options
| author | Todd Broch <tbroch@chromium.org> | 2015-05-29 13:17:33 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-05-30 01:04:47 +0000 |
| commit | 61ee1d732368da2e3c6e51ebf9102969273c11a8 (patch) | |
| tree | f92cf6cadde1dc86a1f823cec0dea6122b4f2261 /board/hoho | |
| parent | 362ed174eb63246ec5f1fc06eb7911eef785acae (diff) | |
| download | chrome-ec-61ee1d732368da2e3c6e51ebf9102969273c11a8.tar.gz | |
mcdp28x0: Use custom appstest command for get_info
Firmware's original get_info command always returns the same values
for family, chipid, irom & fw despite indeed having different
versions.
Currently its:
family:000e chipid:0001 irom:1.0.0 fw:0.0.0
As we have a new stepping of the chip ('BB') and a corresponding new
firmware (>=0.74) we need a mechanism to verify and log this change.
CL uses the newly hatched appstest command (0x12) message 0x28 to
surface information that properly reflects both hardware and firmware
running.
Signed-off-by: Todd Broch <tbroch@chromium.org>
BRANCH=samus
BUG=chrome-os-partner:35939
TEST=manual,
For devices running 0.54 | 0.74 fw see gpio MCDP_READY asserted.
With CONFIG_CMD_MCDP in board/hoho/board.h see the following responses
when executing 'mcdp info'
Stepping | FW | Response
--------------------------------------------------------------------
'BA' 0.53 fails as expected
'BA' 0.54 family:0010 chipid:2850 irom:2.0.0 fw:0.54.0
'BB' 0.73 fails as expected
'BB' 0.74 family:0010 chipid:2850 irom:2.1.0 fw:0.74.0
Change-Id: I2c36393a298c617f903389dab24da631b60ec574
Reviewed-on: https://chromium-review.googlesource.com/274049
Reviewed-by: Scott Collyer <scollyer@chromium.org>
Commit-Queue: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Diffstat (limited to 'board/hoho')
| -rw-r--r-- | board/hoho/board.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/board/hoho/board.c b/board/hoho/board.c index 8e0a370bf3..56484bc0a7 100644 --- a/board/hoho/board.c +++ b/board/hoho/board.c @@ -141,8 +141,8 @@ static void factory_validation_deferred(void) mcdp_enable(); /* test mcdp via serial to validate function */ - if (!mcdp_get_info(&info) && (MCDP_FAMILY(info.family) == 0xe) && - (MCDP_CHIPID(info.chipid) == 0x1)) { + if (!mcdp_get_info(&info) && (MCDP_FAMILY(info.family) == 0x0010) && + (MCDP_CHIPID(info.chipid) == 0x2850)) { gpio_set_level(GPIO_MCDP_READY, 1); pd_log_event(PD_EVENT_VIDEO_CODEC, PD_LOG_PORT_SIZE(0, sizeof(info)), |