summaryrefslogtreecommitdiff
path: root/board/kevin
diff options
context:
space:
mode:
authorShawn Nematbakhsh <shawnn@chromium.org>2016-09-01 13:59:14 -0700
committerchrome-bot <chrome-bot@chromium.org>2016-09-02 07:11:25 -0700
commit6910f907a6384cf94e58927fa1b1221ba84ebe1a (patch)
tree782aa90c8a1107f91099248d508e5230e76f94e3 /board/kevin
parenta2552fdfba11ac0a82fd9f2be87e6e84fd4180dc (diff)
downloadchrome-ec-6910f907a6384cf94e58927fa1b1221ba84ebe1a.tar.gz
kevin / gru: Remove internal PU on LID_ACCEL_INT_L
LID_ACCEL_INT_L is a push / pull interrupt pin which is currently unused by EC FW. Remove the PU to prevent leakage when PP1800_sensor is powered down. BUG=chrome-os-partner:56646 BRANCH=None TEST=On kevin, verify LID_ACCEL_INT_L is consistently logic 0 in S5. Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Change-Id: I6c748a18bcd183f799b78b4ad9098fff7a7d6567 Reviewed-on: https://chromium-review.googlesource.com/380236 Commit-Ready: Shawn N <shawnn@chromium.org> Tested-by: Caesar Wang <wxt@rock-chips.com> Tested-by: Shawn N <shawnn@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'board/kevin')
-rw-r--r--board/kevin/gpio.inc4
1 files changed, 2 insertions, 2 deletions
diff --git a/board/kevin/gpio.inc b/board/kevin/gpio.inc
index 62b8d1f6c8..6828ecef53 100644
--- a/board/kevin/gpio.inc
+++ b/board/kevin/gpio.inc
@@ -90,8 +90,8 @@ GPIO(I2C3_SDA, PIN(D, 0), GPIO_ODR_HIGH)
/* TODO - configure 32KCLKIN for alternate mode */
GPIO(CLK_32K_IN, PIN(E, 7), GPIO_INPUT)
-/* TODO - check if internal PU is needed */
-GPIO(LID_ACCEL_INT_L, PIN(C, 7), GPIO_INPUT | GPIO_PULL_UP)
+/* Attached to push-pull interrupt pin of accel, but unused */
+GPIO(LID_ACCEL_INT_L, PIN(C, 7), GPIO_INPUT)
/* KSO2 is inverted */
GPIO(KBD_KSO2, PIN(1, 7), GPIO_OUT_LOW)