diff options
| author | jerry2.huang <jerry2.huang@lcfc.corp-partner.google.com> | 2021-01-26 17:05:30 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-02-01 08:28:41 +0000 |
| commit | b7043cbd98fc5889bfbd6ef607f95334cb827c08 (patch) | |
| tree | 32228784c67ee34a8f25110557de3d21871e86ed /board/lindar | |
| parent | d135e6ef07da3dc1daff345e5f95da49bf3f7b90 (diff) | |
| download | chrome-ec-b7043cbd98fc5889bfbd6ef607f95334cb827c08.tar.gz | |
lindar: modify led behavior
1.LED color:
LED_1_L color change to green
LED_2_L color change to red
2.Modify led behavior
BUG=b:174443628
BRANCH=firmware-volteer-13672.B
TEST=make buildall ,Verify "green LED at full charge,
amber during charging,red during charging/low battery,
LED off at discharge,red led blink at battery error"
the led behavior is normally.
Signed-off-by: jerry2.huang <jerry2.huang@lcfc.corp-partner.google.com>
Change-Id: I74b6a83d2a252001baa76584ab7f5e58b1129358
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2657904
Reviewed-by: Keith Short <keithshort@chromium.org>
Diffstat (limited to 'board/lindar')
| -rw-r--r-- | board/lindar/gpio.inc | 4 | ||||
| -rw-r--r-- | board/lindar/led.c | 12 |
2 files changed, 8 insertions, 8 deletions
diff --git a/board/lindar/gpio.inc b/board/lindar/gpio.inc index 50d4eb1b4a..b60fb75717 100644 --- a/board/lindar/gpio.inc +++ b/board/lindar/gpio.inc @@ -128,8 +128,8 @@ GPIO(EC_I2C7_EEPROM_SDA, PIN(B, 2), GPIO_INPUT) GPIO(EC_BATT_PRES_ODL, PIN(E, 1), GPIO_INPUT) /* LED */ -GPIO(LED_1_L, PIN(C, 4), GPIO_OUT_HIGH) /* Battery - White LED */ -GPIO(LED_2_L, PIN(C, 3), GPIO_OUT_HIGH) /* Battery - Amber LED */ +GPIO(LED_1_L, PIN(C, 4), GPIO_OUT_HIGH) /* Battery - Green LED */ +GPIO(LED_2_L, PIN(C, 3), GPIO_OUT_HIGH) /* Battery - Red LED */ GPIO(LED_3_L, PIN(C, 2), GPIO_OUT_HIGH) /* Power - White LED */ /* Alternate functions GPIO definitions */ diff --git a/board/lindar/led.c b/board/lindar/led.c index e9922b70cd..7f86a9b89e 100644 --- a/board/lindar/led.c +++ b/board/lindar/led.c @@ -18,9 +18,9 @@ const int led_charge_lvl_1 = 5; const int led_charge_lvl_2 = 97; struct led_descriptor led_bat_state_table[LED_NUM_STATES][LED_NUM_PHASES] = { - [STATE_CHARGING_LVL_1] = {{EC_LED_COLOR_AMBER, LED_INDEFINITE} }, + [STATE_CHARGING_LVL_1] = {{EC_LED_COLOR_RED, LED_INDEFINITE} }, [STATE_CHARGING_LVL_2] = {{EC_LED_COLOR_AMBER, LED_INDEFINITE} }, - [STATE_CHARGING_FULL_CHARGE] = {{EC_LED_COLOR_WHITE, LED_INDEFINITE} }, + [STATE_CHARGING_FULL_CHARGE] = {{EC_LED_COLOR_GREEN, LED_INDEFINITE} }, [STATE_DISCHARGE_S0] = {{LED_OFF, LED_INDEFINITE} }, [STATE_DISCHARGE_S3] = {{LED_OFF, LED_INDEFINITE} }, [STATE_DISCHARGE_S5] = {{LED_OFF, LED_INDEFINITE} }, @@ -60,14 +60,14 @@ void led_set_color_battery(enum ec_led_colors color) { switch (color) { case EC_LED_COLOR_AMBER: - gpio_set_level(GPIO_LED_1_L, LED_OFF_LVL); + gpio_set_level(GPIO_LED_1_L, LED_ON_LVL); gpio_set_level(GPIO_LED_2_L, LED_ON_LVL); break; case EC_LED_COLOR_RED: - gpio_set_level(GPIO_LED_1_L, LED_ON_LVL); + gpio_set_level(GPIO_LED_1_L, LED_OFF_LVL); gpio_set_level(GPIO_LED_2_L, LED_ON_LVL); break; - case EC_LED_COLOR_WHITE: + case EC_LED_COLOR_GREEN: gpio_set_level(GPIO_LED_1_L, LED_ON_LVL); gpio_set_level(GPIO_LED_2_L, LED_OFF_LVL); break; @@ -83,7 +83,7 @@ void led_get_brightness_range(enum ec_led_id led_id, uint8_t *brightness_range) if (led_id == EC_LED_ID_BATTERY_LED) { brightness_range[EC_LED_COLOR_RED] = 1; brightness_range[EC_LED_COLOR_AMBER] = 1; - brightness_range[EC_LED_COLOR_WHITE] = 1; + brightness_range[EC_LED_COLOR_GREEN] = 1; } else if (led_id == EC_LED_ID_POWER_LED) { brightness_range[EC_LED_COLOR_WHITE] = 1; } |