summaryrefslogtreecommitdiff
path: root/board/lingcod
diff options
context:
space:
mode:
authorWai-Hong Tam <waihong@google.com>2021-08-03 17:17:56 -0700
committerCommit Bot <commit-bot@chromium.org>2021-08-05 00:13:33 +0000
commit2eb53a39662b905c65015bafb5f73ab2324d369c (patch)
tree6352433557cdb05c75b1eef449c9ecf844bfc3d0 /board/lingcod
parentfc016f2dce16d0555deee69e00ea5a626eb27f21 (diff)
downloadchrome-ec-2eb53a39662b905c65015bafb5f73ab2324d369c.tar.gz
lid_angle: Create a common callback for lid angle changes
Each board defines its own callback lid_angle_peripheral_enable(). The implementation is very similar. Create a common implementation and reduce the duplicated code. This CL removes the board callbacks which are identifical to the common callback. If it is slightly different, keep it and add the __override tag. The check of TEST_BUILD is unnecessary as the board callback is not linked in the test build. BRANCH=None BUG=b:194922043 TEST=Build all the images. Change-Id: I73d381730f35b80eff69399cdfc5fb54f839aee0 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3069175 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'board/lingcod')
-rw-r--r--board/lingcod/board.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/board/lingcod/board.c b/board/lingcod/board.c
index 88913a63af..feeed33119 100644
--- a/board/lingcod/board.c
+++ b/board/lingcod/board.c
@@ -96,8 +96,7 @@ int board_is_lid_angle_tablet_mode(void)
}
/* Enable or disable input devices, based on tablet mode or chipset state */
-#ifndef TEST_BUILD
-void lid_angle_peripheral_enable(int enable)
+__override void lid_angle_peripheral_enable(int enable)
{
if (ec_cfg_has_tabletmode()) {
if (chipset_in_state(CHIPSET_STATE_ANY_OFF) ||
@@ -106,7 +105,6 @@ void lid_angle_peripheral_enable(int enable)
keyboard_scan_enable(enable, KB_SCAN_DISABLE_LID_ANGLE);
}
}
-#endif
/******************************************************************************/
/* Sensors */