diff options
| author | Vic Yang <victoryang@chromium.org> | 2013-08-28 10:28:08 +0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2013-09-04 05:45:52 +0000 |
| commit | 2270f2bb03c2031bad455ba5f8179a9d99cc3999 (patch) | |
| tree | 496418ddfebf04e0b010c9916bb7b6f0c0036d5d /board/link | |
| parent | b99f91310721c50ea30fd204aa127928af37a41f (diff) | |
| download | chrome-ec-2270f2bb03c2031bad455ba5f8179a9d99cc3999.tar.gz | |
Fix a bug that GPIO cannot be set as input on stm32l
GPIO_INPUT is defined as 0, and any GPIO flag cannot be examined against
GPIO_INPUT. Change GPIO_INPUT to non-zero value to avoid this.
BUG=chrome-os-partner:22275
TEST=On Kirby, set a GPIO to output and pull it low, and then set it back to
input. Check it can be pull high externally.
TEST=Build all boards.
TEST=Boot link and spring.
BRANCH=None (unless this bug hits some other boards.)
Change-Id: I84b9936c24af538ac59c36129fda27ca879bf9d1
Signed-off-by: Vic Yang <victoryang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/167190
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Diffstat (limited to 'board/link')
| -rw-r--r-- | board/link/board.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/board/link/board.c b/board/link/board.c index 618700f388..701f67e24c 100644 --- a/board/link/board.c +++ b/board/link/board.c @@ -37,13 +37,13 @@ const struct gpio_info gpio_list[] = { {"LID_OPEN", LM4_GPIO_K, (1<<5), GPIO_INT_BOTH, lid_interrupt}, /* Other inputs */ - {"THERMAL_DATA_READY_L", LM4_GPIO_B, (1<<4), 0, NULL}, + {"THERMAL_DATA_READY_L", LM4_GPIO_B, (1<<4), GPIO_INPUT, NULL}, {"AC_PRESENT", LM4_GPIO_H, (1<<3), GPIO_INT_BOTH, extpower_interrupt}, - {"BOARD_VERSION1", LM4_GPIO_H, (1<<6), 0, NULL}, - {"BOARD_VERSION2", LM4_GPIO_L, (1<<6), 0, NULL}, - {"BOARD_VERSION3", LM4_GPIO_L, (1<<7), 0, NULL}, - {"ONEWIRE", LM4_GPIO_H, (1<<2), 0, NULL}, + {"BOARD_VERSION1", LM4_GPIO_H, (1<<6), GPIO_INPUT, NULL}, + {"BOARD_VERSION2", LM4_GPIO_L, (1<<6), GPIO_INPUT, NULL}, + {"BOARD_VERSION3", LM4_GPIO_L, (1<<7), GPIO_INPUT, NULL}, + {"ONEWIRE", LM4_GPIO_H, (1<<2), GPIO_INPUT, NULL}, {"PCH_BKLTEN", LM4_GPIO_J, (1<<3), GPIO_INT_BOTH, backlight_interrupt}, {"PCH_SLP_A_L", LM4_GPIO_G, (1<<5), GPIO_INT_BOTH, @@ -78,8 +78,8 @@ const struct gpio_info gpio_list[] = { x86_interrupt}, {"RECOVERY_L", LM4_GPIO_H, (1<<7), GPIO_INT_BOTH, switch_interrupt}, - {"USB1_STATUS_L", LM4_GPIO_E, (1<<7), 0, NULL}, - {"USB2_STATUS_L", LM4_GPIO_E, (1<<1), 0, NULL}, + {"USB1_STATUS_L", LM4_GPIO_E, (1<<7), GPIO_INPUT, NULL}, + {"USB2_STATUS_L", LM4_GPIO_E, (1<<1), GPIO_INPUT, NULL}, {"WP", LM4_GPIO_J, (1<<4), GPIO_INT_BOTH, switch_interrupt}, /* Outputs; all unasserted by default except for reset signals */ |