diff options
| author | Rob Barnes <robbarnes@google.com> | 2021-01-29 07:20:54 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-05-26 00:15:34 +0000 |
| commit | b657c3e96d1809e82554f8c859afffba358a3567 (patch) | |
| tree | 96ffeeda502d3b2fbec7cf472a56d0370c6d5c1c /board/morphius | |
| parent | 4304fe55704c5234545d06223f9c632e5b9fe8d4 (diff) | |
| download | chrome-ec-b657c3e96d1809e82554f8c859afffba358a3567.tar.gz | |
usb_common: Assert CCD_MODE when DTS connected
Drive CCD_MODE_ODL from EC when EC sees DTS connected to CCD port.
This will fix some cases where the Cr50 is not able to detect that
a CCD debug cable has been connected.
BUG=b:175056327
TEST=Connect/disconnect SuzyQ cable, see assert/unassert in log
Check gpioget on CR50 and ec, confirm CCD_MODE_ODL is correct
Connect/disconnect charger, do not see assert/unassert in log
Repeat with ServoV4
BRANCH=None
Change-Id: I411e75a47f2e1303ddbd9caa63a9417630c99b46
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2659282
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Diffstat (limited to 'board/morphius')
| -rw-r--r-- | board/morphius/board.h | 1 | ||||
| -rw-r--r-- | board/morphius/gpio.inc | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/board/morphius/board.h b/board/morphius/board.h index ec062011c7..45fae888aa 100644 --- a/board/morphius/board.h +++ b/board/morphius/board.h @@ -19,6 +19,7 @@ #define CONFIG_CMD_PS2 #define CONFIG_KEYBOARD_FACTORY_TEST #define CONFIG_DEVICE_EVENT +#define CONFIG_ASSERT_CCD_MODE_ON_DTS_CONNECT #undef CONFIG_LED_ONOFF_STATES #define CONFIG_BATTERY_LEVEL_NEAR_FULL 91 diff --git a/board/morphius/gpio.inc b/board/morphius/gpio.inc index e200b8e268..f14c56c66f 100644 --- a/board/morphius/gpio.inc +++ b/board/morphius/gpio.inc @@ -33,7 +33,7 @@ GPIO_INT(DP1_HPD_EC_IN, PIN(7, 5), GPIO_INT_BOTH, hdmi_hpd_interrupt_v3) GPIO(EC_RST_ODL, PIN(0, 2), GPIO_INT_BOTH | GPIO_HIB_WAKE_HIGH) GPIO(3AXIS_INT_L, PIN(9, 6), GPIO_INPUT | GPIO_PULL_DOWN) /* 3 Axis Accel */ -GPIO(CCD_MODE_ODL, PIN(C, 6), GPIO_INPUT) /* Case Closed Debug Mode */ +GPIO(CCD_MODE_ODL, PIN(C, 6), GPIO_ODR_HIGH) /* Case Closed Debug Mode */ GPIO(PROCHOT_ODL, PIN(D, 5), GPIO_ODR_HIGH) /* PROCHOT to SOC */ GPIO(EC_BATT_PRES_ODL, PIN(4, 1), GPIO_INPUT) /* Battery Present */ GPIO(EC_AP_INT_ODL, PIN(A, 3), GPIO_ODR_HIGH) /* Sensor MKBP event to SOC */ |