diff options
| author | Craig Hesling <hesling@chromium.org> | 2020-12-08 08:17:24 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-12-08 23:31:45 +0000 |
| commit | e1718af45bb6fe5a7da9572280674122249ae2c1 (patch) | |
| tree | db102d6527a3b870b3286eff2e1d9ae4a0c834a5 /board/nocturne_fp | |
| parent | b5b7e4500c407e57e4d734bbd42b3a100dd08e96 (diff) | |
| download | chrome-ec-e1718af45bb6fe5a7da9572280674122249ae2c1.tar.gz | |
dartmonkey: Note for unused SLP_S4_L and SLP_SUS_L
These sleep lines were never used in code and have since been removed
from the reference schematic, but they are driven on nocturne.
This means that it would be bad if thee lines were ever accidentally
repurposed in the future.
Confirmed on A70 PVT/MP schematic.
TEST=make BOARD=dartmonkey
BUG=b:175115925
Change-Id: I3d1e3bbee5d242026a37464f6f0154243e262972
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2579463
Tested-by: Craig Hesling <hesling@chromium.org>
Auto-Submit: Craig Hesling <hesling@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Commit-Queue: Craig Hesling <hesling@chromium.org>
Diffstat (limited to 'board/nocturne_fp')
| -rw-r--r-- | board/nocturne_fp/gpio.inc | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/board/nocturne_fp/gpio.inc b/board/nocturne_fp/gpio.inc index 48a15209ba..a5ac01f1b3 100644 --- a/board/nocturne_fp/gpio.inc +++ b/board/nocturne_fp/gpio.inc @@ -10,7 +10,11 @@ GPIO_INT(SPI1_NSS, PIN(A, 4), GPIO_INPUT, spi_event) GPIO_INT(PCH_SLP_S0_L, PIN(D,13), GPIO_INT_BOTH, slp_event) GPIO_INT(PCH_SLP_S3_L, PIN(A,11), GPIO_INT_BOTH, slp_event) - +/* + * The S4 and SUS sleep lines are unused in code, but are maintained in this + * gpio list to ensure that they are not repurposed. This is because these + * inputs are driven on nocturne. + */ GPIO(PCH_SLP_S4_L, PIN(D, 8), GPIO_INPUT) GPIO(PCH_SLP_SUS_L, PIN(D, 3), GPIO_INPUT) #if defined(APPLY_RESET_LOOP_FIX) && defined(SECTION_IS_RW) |