diff options
| author | Todd Broch <tbroch@chromium.org> | 2015-06-16 15:42:13 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-06-17 13:10:51 +0000 |
| commit | b33531e262561e297ba1a02fc829a2110c6df515 (patch) | |
| tree | d04c52ccf76036cda1a1b2389e6636660179b496 /board/oak/usb_pd_policy.c | |
| parent | 859f4d50adf6f5732970239fb72fd521eb693c16 (diff) | |
| download | chrome-ec-b33531e262561e297ba1a02fc829a2110c6df515.tar.gz | |
pd: Fix pin mode field in DP config VDM.
VESA SCR titled,
'DP Alt Mode Plug Corrections & Protocol Clarif'
Simplified the DP config mode VDM to longer include two separate bytes
for UFP vs DFP pin modes since bits <1:0> designate the desired port
direction.
This change corrects our VDM accordingly so that <23:16> are now zero
(SBZ) and <15:8> carry the appropriate pin mode.
Signed-off-by: Todd Broch <tbroch@chromium.org>
BRANCH=samus_pd
BUG=chromium:501002
TEST=manual,
1. samus -> hoho, dingdong or apple hdmi dongles still drive DPout
2. twinkie console output samus -> hoho shows correct DP config VDM
369.275296 SRC/2 [256f]VDM Vff01:DPCFG,INI:ff018111 00000406
where:
<31:16> = SBZ == 0x0000
<15:08> = PIN_C == 0x04
Change-Id: I1146045dd94458c82b7ed08940af6009658afa05
Reviewed-on: https://chromium-review.googlesource.com/278083
Commit-Queue: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Alec Berg <alecaberg@chromium.org>
Diffstat (limited to 'board/oak/usb_pd_policy.c')
| -rw-r--r-- | board/oak/usb_pd_policy.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/board/oak/usb_pd_policy.c b/board/oak/usb_pd_policy.c index 5f403ba45a..cc7abc60d6 100644 --- a/board/oak/usb_pd_policy.c +++ b/board/oak/usb_pd_policy.c @@ -270,8 +270,7 @@ static int svdm_dp_config(int port, uint32_t *payload) /* board_set_usb_mux(port, TYPEC_MUX_DP, pd_get_polarity(port)); */ payload[0] = VDO(USB_SID_DISPLAYPORT, 1, CMD_DP_CONFIG | VDO_OPOS(opos)); - payload[1] = VDO_DP_CFG(MODE_DP_PIN_E, /* sink pins */ - MODE_DP_PIN_E, /* src pins */ + payload[1] = VDO_DP_CFG(MODE_DP_PIN_E, /* pin mode */ 1, /* DPv1.3 signaling */ 2); /* UFP connected */ return 2; |