diff options
| author | Scott <scollyer@chromium.org> | 2015-07-23 18:59:41 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-07-27 19:30:55 +0000 |
| commit | 198fd7f2c2cc09df0bc28406051a14b2c8bd401c (patch) | |
| tree | 55ac9223db9e72201bd32b9efbc74b01541b2258 /board/oak_pd | |
| parent | af7fb66ae3ae4f5741a05961658f4a6fa9beae6e (diff) | |
| download | chrome-ec-198fd7f2c2cc09df0bc28406051a14b2c8bd401c.tar.gz | |
oak: Fix issue with pc_send_ec_int() function
There was a bug in this function where the bit for host_command was
being set in the ec_status variable. This caused the ALERT# GPIO
line to be held low which in turn caused the EC MCU to loop
and keep reading the ALERT register.
BUG=none
BRANCH=none
TEST=manual Tested against Zinger in both ports and Zinger and Samus
at connected into each port. Verified that it established a PD contract
for both ports and that the alert line was no longer being held low
Change-Id: I5540440a68581521eb002411f728a4eac2f22caf
Signed-off-by: Scott Collyer <scollyer@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/288252
Reviewed-by: Alec Berg <alecaberg@chromium.org>
Commit-Queue: Alec Berg <alecaberg@chromium.org>
Tested-by: Alec Berg <alecaberg@chromium.org>
Diffstat (limited to 'board/oak_pd')
| -rw-r--r-- | board/oak_pd/board.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/board/oak_pd/board.c b/board/oak_pd/board.c index df550b4e26..4b37a1efb2 100644 --- a/board/oak_pd/board.c +++ b/board/oak_pd/board.c @@ -25,8 +25,6 @@ static uint32_t ec_int_status; void pd_send_ec_int(void) { - /* Indicate that ec_int gpio is active due to host command */ - atomic_or(&ec_int_status, PD_STATUS_HOST_EVENT); /* If any sources are active, then drive the line low */ gpio_set_level(GPIO_EC_INT, !ec_int_status); |