summaryrefslogtreecommitdiff
path: root/board/pit
diff options
context:
space:
mode:
authorRandall Spangler <rspangler@chromium.org>2013-10-24 11:18:47 -0700
committerchrome-internal-fetch <chrome-internal-fetch@google.com>2013-10-25 01:32:15 +0000
commitdf541c6ffdc3ecf2802bad1c235e730cd29f8bfb (patch)
tree5de1078e831ec5e3f3f7437b6e5e8c96b4156a69 /board/pit
parent4a1ecb67f9ff1745422aecdd5cc70a9f630d7dc8 (diff)
downloadchrome-ec-df541c6ffdc3ecf2802bad1c235e730cd29f8bfb.tar.gz
cleanup: rename I2C_PORT_HOST to I2C_PORT_MASTER
Previously, it was really confusing whether I2C_PORT_HOST meant the port where the EC was the master, or the port used to talk to the AP. No functional changes, just a global find/replace and some tidying of unused comments. BUG=chrome-os-partner:18343 BRANCH=none TEST=build all platforms; pass unit tests Change-Id: Ia591ba4577d3399729556e0234ba0db3a0e3c5ea Signed-off-by: Randall Spangler <rspangler@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/174546 Reviewed-by: Alec Berg <alecaberg@chromium.org>
Diffstat (limited to 'board/pit')
-rw-r--r--board/pit/board.c2
-rw-r--r--board/pit/board.h19
2 files changed, 5 insertions, 16 deletions
diff --git a/board/pit/board.c b/board/pit/board.c
index b4c5cc0d6e..a54bfac6ba 100644
--- a/board/pit/board.c
+++ b/board/pit/board.c
@@ -107,7 +107,7 @@ const struct battery_temperature_ranges bat_temp_ranges = {
/* I2C ports */
const struct i2c_port_t i2c_ports[] = {
- {"host", I2C_PORT_HOST, 100},
+ {"master", I2C_PORT_MASTER, 100},
};
const unsigned int i2c_ports_used = ARRAY_SIZE(i2c_ports);
diff --git a/board/pit/board.h b/board/pit/board.h
index c9c82e5048..2f95545e90 100644
--- a/board/pit/board.h
+++ b/board/pit/board.h
@@ -43,21 +43,10 @@ enum module_id {
/* Keyboard output port list */
#define KB_OUT_PORT_LIST GPIO_A, GPIO_B, GPIO_C
-/*
- * Charging.
- *
- * "HOST" means the port where the EC is the master, which has the battery,
- * charger and PMU.
- *
- * "SLAVE" means the port where the EC is the slave, which has the AP (host
- * processor).
- *
- * TODO: In this context, "host" is badly overloaded and confusing.
- */
-#define I2C_PORT_HOST 0
-#define I2C_PORT_BATTERY I2C_PORT_HOST
-#define I2C_PORT_CHARGER I2C_PORT_HOST
-#define I2C_PORT_SLAVE 1
+/* Single I2C port, where the EC is the master. */
+#define I2C_PORT_MASTER 0
+#define I2C_PORT_BATTERY I2C_PORT_MASTER
+#define I2C_PORT_CHARGER I2C_PORT_MASTER
/* Charger sense resistors */
#define CONFIG_CHARGER_SENSE_RESISTOR_AC 12