summaryrefslogtreecommitdiff
path: root/board/plankton
diff options
context:
space:
mode:
authorBill Richardson <wfrichar@chromium.org>2016-02-25 10:48:10 -0800
committerchrome-bot <chrome-bot@chromium.org>2016-02-25 18:25:37 -0800
commit5a9a8f3dbf93cb651bef6ffbd420a24ca5ee01aa (patch)
treeaa3ab4c3d1df46023986975ff757d5135c5c4163 /board/plankton
parent8376cf5ccae5462287c806cd9b2cb859b5f8f806 (diff)
downloadchrome-ec-5a9a8f3dbf93cb651bef6ffbd420a24ca5ee01aa.tar.gz
cleanup: Add warning comment to gpio.inc files
With commit e9883124ff16, a GPIO_INT macro was added. That change also required that all instances of GPIO_INT in a board's gpio.inc file come before any GPIO macros, or the interrupt handler wouldn't work properly. This CL just adds a warning comment about requirement to all gpio.inc files. BUG=chromium:471331 BRANCH=none TEST=make buildall, test image on Cr50 This is a change to comments only. There is no new behavior to verify, although I did run try out one new image just to be sure nothing stupid happened. Change-Id: I83f7819929a53bce3a8bae04d15b3ee3bda11738 Signed-off-by: Bill Richardson <wfrichar@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/329334 Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Diffstat (limited to 'board/plankton')
-rw-r--r--board/plankton/gpio.inc4
1 files changed, 3 insertions, 1 deletions
diff --git a/board/plankton/gpio.inc b/board/plankton/gpio.inc
index 1f97b63fed..b090f4154f 100644
--- a/board/plankton/gpio.inc
+++ b/board/plankton/gpio.inc
@@ -5,7 +5,9 @@
* found in the LICENSE file.
*/
-/* Inputs with interrupt handlers are first for efficiency */
+/* Declare symbolic names for all the GPIOs that we care about.
+ * Note: Those with interrupt handlers must be declared first. */
+
GPIO_INT(VBUS_WAKE, PIN(B, 5), GPIO_INT_BOTH, vbus_event)
GPIO_INT(DPSRC_HPD, PIN(B, 13), GPIO_INT_BOTH, hpd_event)
GPIO_INT(DBG_12V_TO_DUT_L, PIN(B, 14), GPIO_INT_FALLING, button_event)