diff options
| author | Douglas Anderson <dianders@chromium.org> | 2020-07-25 15:48:33 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-07-27 18:56:27 +0000 |
| commit | 5e6ed41212cb932efea7576eca65108a5173cc77 (patch) | |
| tree | 44b9b80ddf36dec091bfe62bf961b544fe1d097e /board/pompom/ec.tasklist | |
| parent | a89bf25b756fc683c009a62433e0c859915eae0c (diff) | |
| download | chrome-ec-5e6ed41212cb932efea7576eca65108a5173cc77.tar.gz | |
trogdor: Increase HOSTCMD task stack size
Running "taskinfo" on a lazor device (in this case, right after
running chrome://system) shows that we're very close to the edge.
Presumably we actually go over the edge in some situations since we've
seen cases where going to chrome://system gets a stack overflow crash
reported against the HOSTCMD task.
After this change, taskinfo (after running chrome://system) looks like:
> taskinfo
Task Ready Name Events Time (s) StkUsed
0 R << idle >> 00000001 141.717533 112/672
1 HOOKS 00000000 0.402382 656/800
2 USB_CHG_P0 00000000 0.006707 448/672
3 USB_CHG_P1 00000000 0.000214 440/672
4 CHIPSET 00000000 0.002645 536/800
5 CHARGER 00000000 0.853712 560/800
6 R MOTIONSENSE 00000002 1.677563 696/928
7 R HOSTCMD 00000001 1.379692 792/928
8 R CONSOLE 00000000 0.172554 384/800
9 KEYSCAN 00000000 1.970870 308/672
10 PD_C0 00000000 3.960594 584/800
11 PD_C1 00000000 0.056556 584/800
12 PD_INT_C0 00000000 0.026221 544/672
13 PD_INT_C1 00000000 0.006403 480/672
BRANCH=None
BUG=b:162039557
TEST=taskinfo looks good now
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Change-Id: I5c2ff959e37b26f2dcda64536a8d3ecb1dd247e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2318635
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Reviewed-by: Philip Chen <philipchen@chromium.org>
Diffstat (limited to 'board/pompom/ec.tasklist')
| -rw-r--r-- | board/pompom/ec.tasklist | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/pompom/ec.tasklist b/board/pompom/ec.tasklist index 824d237892..b213687675 100644 --- a/board/pompom/ec.tasklist +++ b/board/pompom/ec.tasklist @@ -14,7 +14,7 @@ TASK_NOTEST(CHIPSET, chipset_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_ALWAYS(CHARGER, charger_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_ALWAYS(MOTIONSENSE, motion_sense_task, NULL, VENTI_TASK_STACK_SIZE) \ - TASK_ALWAYS(HOSTCMD, host_command_task, NULL, LARGER_TASK_STACK_SIZE) \ + TASK_ALWAYS(HOSTCMD, host_command_task, NULL, VENTI_TASK_STACK_SIZE) \ TASK_ALWAYS(CONSOLE, console_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_NOTEST(KEYSCAN, keyboard_scan_task, NULL, TASK_STACK_SIZE) \ TASK_ALWAYS(PD_C0, pd_task, NULL, LARGER_TASK_STACK_SIZE) \ |