diff options
| author | Wai-Hong Tam <waihong@google.com> | 2020-10-19 12:02:47 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-10-20 03:45:43 +0000 |
| commit | d3188e71f4643ca787f2cbb03c456b534f6f7c8f (patch) | |
| tree | faa9aef9daeddfc2d98075a5d574535d78c52ef9 /board/pompom | |
| parent | e882e9482e112f2f6594d8f278467aac865f28a2 (diff) | |
| download | chrome-ec-d3188e71f4643ca787f2cbb03c456b534f6f7c8f.tar.gz | |
Trogdor: Remove GPIO 1.8V flags
The supply of the following GPIOs are VSPI/VHIF which is 1.8V. Their
voltage levels are not configurable. The 1.8V flag is unnecessary.
* PS_HOLD
* PMIC_FAULT_L
* AP_SUSPEND
* ACCEL_GYRO_INT_L
The following GPIOs are on 3.3V supply and not configurable. The 1.8V
flag doesn't work. As they are used as open-drain, should be fine.
* PM845_RESIN_L
* PMIC_KPD_PWR_ODL
BRANCH=None
BUG=b:169595541
TEST=Tested the power-on and power-off sequence.
Change-Id: I309c1a925b78e1140967cf3702e4ec3bba2a4583
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2485910
Reviewed-by: Alexandru M Stan <amstan@chromium.org>
Diffstat (limited to 'board/pompom')
| -rw-r--r-- | board/pompom/gpio.inc | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/board/pompom/gpio.inc b/board/pompom/gpio.inc index 9d2a453ee0..74dbc2d6b5 100644 --- a/board/pompom/gpio.inc +++ b/board/pompom/gpio.inc @@ -22,9 +22,9 @@ GPIO_INT(EC_VOLUP_BTN_ODL, PIN(F, 2), GPIO_INT_BOTH | GPIO_PULL_UP, button_inte GPIO_INT(EC_WP_ODL, PIN(A, 1), GPIO_INT_BOTH, switch_interrupt) /* Write protection */ GPIO_INT(LID_OPEN_EC, PIN(D, 2), GPIO_INT_BOTH, lid_interrupt) /* Lid open */ GPIO_INT(AP_RST_L, PIN(C, 1), GPIO_INT_BOTH | GPIO_SEL_1P8V, chipset_ap_rst_interrupt) /* PMIC to signal AP reset */ -GPIO_INT(PS_HOLD, PIN(A, 4), GPIO_INT_BOTH | GPIO_PULL_DOWN | GPIO_SEL_1P8V, power_signal_interrupt) /* Indicate when AP triggers reset/shutdown */ -GPIO_INT(PMIC_FAULT_L, PIN(A, 3), GPIO_INT_BOTH | GPIO_SEL_1P8V, power_signal_interrupt) /* Any PMIC fault? */ -GPIO_INT(AP_SUSPEND, PIN(5, 7), GPIO_INT_BOTH | GPIO_SEL_1P8V, power_signal_interrupt) /* Suspend signal from PMIC */ +GPIO_INT(PS_HOLD, PIN(A, 4), GPIO_INT_BOTH | GPIO_PULL_DOWN, power_signal_interrupt) /* Indicate when AP triggers reset/shutdown */ +GPIO_INT(PMIC_FAULT_L, PIN(A, 3), GPIO_INT_BOTH, power_signal_interrupt) /* Any PMIC fault? */ +GPIO_INT(AP_SUSPEND, PIN(5, 7), GPIO_INT_BOTH, power_signal_interrupt) /* Suspend signal from PMIC */ GPIO_INT(DEPRECATED_AP_RST_REQ, PIN(C, 2), GPIO_INT_BOTH | GPIO_PULL_DOWN | GPIO_SEL_1P8V, power_signal_interrupt) /* Deprecated AP initiated reset indicator */ /* * When switch-cap is off, the POWER_GOOD signal is floating. Need a pull-down @@ -38,7 +38,7 @@ GPIO_INT(AP_EC_SPI_CS_L, PIN(5, 3), GPIO_INT_FALLING | GPIO_PULL_DOWN, shi_cs /* Sensor interrupts */ GPIO_INT(LID_360_L, PIN(7, 2), GPIO_INT_BOTH, gmr_tablet_switch_isr) -GPIO_INT(ACCEL_GYRO_INT_L, PIN(A, 0), GPIO_INT_FALLING | GPIO_SEL_1P8V, bmi160_interrupt) /* Accelerometer/gyro interrupt */ +GPIO_INT(ACCEL_GYRO_INT_L, PIN(A, 0), GPIO_INT_FALLING, bmi160_interrupt) /* Accelerometer/gyro interrupt */ /* * EC_RST_ODL acts as a wake source from hibernate mode. However, it does not @@ -49,8 +49,8 @@ GPIO(EC_ENTERING_RW, PIN(E, 1), GPIO_OUT_LOW) /* Indicate when EC is en GPIO(EC_BATT_PRES_ODL, PIN(E, 5), GPIO_INPUT) /* Battery Present */ /* PMIC/AP 1.8V */ -GPIO(PM7180_RESIN_D_L, PIN(3, 2), GPIO_ODR_HIGH | GPIO_SEL_1P8V) /* PMIC reset trigger */ -GPIO(PMIC_KPD_PWR_ODL, PIN(D, 6), GPIO_ODR_HIGH | GPIO_SEL_1P8V) /* PMIC power button */ +GPIO(PM7180_RESIN_D_L, PIN(3, 2), GPIO_ODR_HIGH) /* PMIC reset trigger */ +GPIO(PMIC_KPD_PWR_ODL, PIN(D, 6), GPIO_ODR_HIGH) /* PMIC power button */ GPIO(EC_INT_L, PIN(A, 2), GPIO_ODR_HIGH) /* Interrupt line between AP and EC */ GPIO(QSIP_ON, PIN(5, 0), GPIO_OUT_LOW) /* Not used, for non-switchcap testing */ |