diff options
| author | Nicolas Boichat <drinkcat@google.com> | 2017-07-27 14:24:55 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-07-27 19:56:25 -0700 |
| commit | 80be36c38ac0ca6c09e38629f835129e0bd278ad (patch) | |
| tree | 559c5b3f49454ebf09fa62e0134c44d2cf3da731 /board/poppy/gpio.inc | |
| parent | e302a0d87fb47f9ec93ccfa771f13f55abd73758 (diff) | |
| download | chrome-ec-80be36c38ac0ca6c09e38629f835129e0bd278ad.tar.gz | |
poppy: Change RTCRST GPIO, LED only moved from rev5
Turns out PCH_RTCRST is never used, and its location is either
GPIOE7 (rev 0-3), or GPIO27 (rev 4-).
- Leaving this pin configured as input (default) for rev0-3 should
be fine as there is an external pull-down.
- We still drive it low from rev4, for consistency.
Also, LED_YELLOW_C0 only moved from GPIO32 to GPIO24 (not GPIO27)
from rev5.
BRANCH=none
BUG=b:63048710
TEST=Boot poppy/soraka
Change-Id: I1c474fe8abb97c75210b81662ba1d1af0a7ee82e
Signed-off-by: Nicolas Boichat <drinkcat@google.com>
Reviewed-on: https://chromium-review.googlesource.com/588428
Commit-Ready: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Diffstat (limited to 'board/poppy/gpio.inc')
| -rw-r--r-- | board/poppy/gpio.inc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/board/poppy/gpio.inc b/board/poppy/gpio.inc index 9de1c7744e..775b352589 100644 --- a/board/poppy/gpio.inc +++ b/board/poppy/gpio.inc @@ -37,7 +37,7 @@ GPIO_INT(ACCELGYRO3_INT_L, PIN(3, 6), GPIO_INT_FALLING, bmi160_interrupt) GPIO_INT(BASE_DET_A, PIN(4, 5), GPIO_INT_BOTH, base_detect_interrupt) GPIO_INT(USB_C0_CABLE_DET, PIN(D, 2), GPIO_INT_RISING, anx74xx_cable_det_interrupt) -GPIO(PCH_RTCRST, PIN(E, 7), GPIO_OUT_LOW) /* RTCRST# to SOC */ +GPIO(PCH_RTCRST, PIN(2, 7), GPIO_OUT_LOW) /* RTCRST# to SOC (>= rev4) */ GPIO(ENABLE_BACKLIGHT, PIN(2, 6), GPIO_OUT_LOW) /* Enable Backlight */ GPIO(WLAN_OFF_L, PIN(7, 2), GPIO_OUT_LOW) /* Disable WLAN */ GPIO(PP3300_DX_WLAN, PIN(A, 7), GPIO_OUT_LOW) /* Enable WLAN 3.3V Power */ @@ -111,8 +111,8 @@ GPIO(USB2_OTG_ID, PIN(A, 1), GPIO_ODR_LOW) /* OTG ID */ GPIO(USB2_OTG_VBUSSENSE, PIN(9, 5), GPIO_OUT_LOW) /* OTG VBUS Sense */ /* LEDs (2 colors on each port) */ -GPIO(LED_YELLOW_C0, PIN(2, 7), GPIO_OUT_LOW) /* This is from rev4 */ -GPIO(LED_YELLOW_C0_OLD, PIN(3, 2), GPIO_OUT_LOW) /* This is for rev1 to rev3 */ +GPIO(LED_YELLOW_C0, PIN(2, 4), GPIO_OUT_LOW) /* This is from rev5 */ +GPIO(LED_YELLOW_C0_OLD, PIN(3, 2), GPIO_OUT_LOW) /* This is for rev1 to rev4 */ GPIO(LED_WHITE_C0, PIN(C, 6), GPIO_OUT_LOW) GPIO(LED_YELLOW_C1, PIN(3, 1), GPIO_OUT_LOW) GPIO(LED_WHITE_C1, PIN(3, 0), GPIO_OUT_LOW) |