diff options
| author | Randall Spangler <rspangler@chromium.org> | 2014-02-28 14:54:05 -0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-03-01 21:57:41 +0000 |
| commit | b805917e43ec2912404892aede64a1265201a4a4 (patch) | |
| tree | cc3c61ce9e49a7b0858c3844827bd2d03c37a7f3 /board/rambi/board.h | |
| parent | e381585619778c4952ada5f3118ec4fcf304eb66 (diff) | |
| download | chrome-ec-b805917e43ec2912404892aede64a1265201a4a4.tar.gz | |
rambi: Remove ignored PCH signalsstabilize-5579.B
The EC had inputs with internal pullups on SUS_STAT#, SUSPWRDNACK, and
SLP_SX#. But we never used those signals for anything. The pullups
cost 1.5 mW power in S3. So, remove those signals and their pullups.
They can be turned back on via CONFIG_CHIPSET_DEBUG.
BUG=chrome-os-partner:25568
BRANCH=rambi
TEST=build with and without CONFIG_CHIPSET_DEBUG. Verify gpioget and
powerindebug show the signals only when it's defined.
Change-Id: I0851243615c91a3aa8aa1b28df70809b578d2e74
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/188389
Reviewed-by: Dave Parker <dparker@chromium.org>
Diffstat (limited to 'board/rambi/board.h')
| -rw-r--r-- | board/rambi/board.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/board/rambi/board.h b/board/rambi/board.h index 3a19a55c71..331fcc17af 100644 --- a/board/rambi/board.h +++ b/board/rambi/board.h @@ -88,9 +88,11 @@ enum gpio_signal { GPIO_BOARD_VERSION1, /* Board version stuffing resistor 1 */ GPIO_BOARD_VERSION2, /* Board version stuffing resistor 2 */ GPIO_BOARD_VERSION3, /* Board version stuffing resistor 3 */ +#ifdef CONFIG_CHIPSET_DEBUG GPIO_PCH_SLP_SX_L, /* SLP_S0IX# signal from PCH */ GPIO_PCH_SUS_STAT_L, /* SUS_STAT# signal from PCH */ GPIO_PCH_SUSPWRDNACK, /* SUSPWRDNACK signal from PCH */ +#endif GPIO_PP1000_S0IX_PGOOD, /* Power good on 1.00V (S0iX supplies) */ GPIO_USB1_OC_L, /* USB port overcurrent warning */ GPIO_USB2_OC_L, /* USB port overcurrent warning */ @@ -145,9 +147,11 @@ enum power_signal { X86_PGOOD_PP1000_S0IX, X86_SLP_S3_DEASSERTED, X86_SLP_S4_DEASSERTED, +#ifdef CONFIG_CHIPSET_DEBUG X86_SLP_SX_DEASSERTED, X86_SUS_STAT_ASSERTED, X86_SUSPWRDNACK_ASSERTED, +#endif /* Number of X86 signals */ POWER_SIGNAL_COUNT |