diff options
| author | Devin Lu <Devin.Lu@quantatw.com> | 2021-07-23 11:27:40 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-07-24 01:23:48 +0000 |
| commit | 916a778365dded01803340a554e83c0fea6c3802 (patch) | |
| tree | 4cc43a4c69aeed4d9f1af77b13b46f8c80260f56 /board/redrix | |
| parent | 72913a8e010f1496b91e3bc4b57a772043ad074f (diff) | |
| download | chrome-ec-916a778365dded01803340a554e83c0fea6c3802.tar.gz | |
Redrix: Tuning TCPC reset timing
BUG=b:193461268
BRANCH=none
TEST=make BOARD=redrix
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: If14e5de907c69fc830167f165c371e1b3e40fb05
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3045431
Reviewed-by: caveh jalali <caveh@chromium.org>
Diffstat (limited to 'board/redrix')
| -rw-r--r-- | board/redrix/usbc_config.c | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/board/redrix/usbc_config.c b/board/redrix/usbc_config.c index 768e6b88cd..906147a696 100644 --- a/board/redrix/usbc_config.c +++ b/board/redrix/usbc_config.c @@ -182,25 +182,23 @@ __override int bb_retimer_power_enable(const struct usb_mux *me, bool enable) void board_reset_pd_mcu(void) { - /* - * TODO(b/193461268): figure out correct timing - */ - gpio_set_level(GPIO_USB_C0_TCPC_RST_ODL, 0); gpio_set_level(GPIO_USB_C1_TCPC_RST_ODL, 0); /* * delay for power-on to reset-off and min. assertion time */ - - msleep(20); + msleep(NCT38XX_RESET_HOLD_DELAY_MS); gpio_set_level(GPIO_USB_C0_TCPC_RST_ODL, 1); gpio_set_level(GPIO_USB_C1_TCPC_RST_ODL, 1); - /* wait for chips to come up */ + nct38xx_reset_notify(USBC_PORT_C0); + nct38xx_reset_notify(USBC_PORT_C1); - msleep(50); + /* wait for chips to come up */ + if (NCT38XX_RESET_POST_DELAY_MS != 0) + msleep(NCT38XX_RESET_POST_DELAY_MS); } static void board_tcpc_init(void) |