diff options
| author | Shamile Khan <shamile.khan@intel.com> | 2016-08-15 17:47:25 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-08-17 19:17:28 -0700 |
| commit | 01732ed87cd42a6d4e8767c4b53cce8f02b6c2e9 (patch) | |
| tree | ee42e1fde8b47c529a984b65bc225db6cf8a4a36 /board/reef/gpio.inc | |
| parent | 2d96f851ab2df57b447e65ac2c2365572223a36d (diff) | |
| download | chrome-ec-01732ed87cd42a6d4e8767c4b53cce8f02b6c2e9.tar.gz | |
reef: Add internal pull-up for TCPC1 INT# by default.
Previously this was only done when the board version is EVT or less
and when daughter card is inserted. However board version can not
be determined at this stage of power up since the function
board_get_version() relies on reading Board ID ADC and ADCs have not
yet been initialized.
This pull up can be removed in future board versions in which the
daughter card will always be in place and an internal pull-up will
no longer be needed.
BUG=chrome-os-partner:55488 chrome-os-partner:56039
BRANCH=none
TEST=verify board has no watchdog reset when daughter baord
is not connected. Also verify from EC log timestamps that
there is no delay of approximately 1 second between
"Inits done"and "KB init state"
Change-Id: I68eff923dd795b7b2f23f88028ee14d1e845b401
Signed-off-by: Shamile Khan <shamile.khan@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/370958
Commit-Ready: Kevin K Wong <kevin.k.wong@intel.com>
Tested-by: Kevin K Wong <kevin.k.wong@intel.com>
Tested-by: Stefan Reinauer <reinauer@google.com>
Reviewed-by: David Hendricks <dhendrix@chromium.org>
Reviewed-by: Kevin K Wong <kevin.k.wong@intel.com>
Diffstat (limited to 'board/reef/gpio.inc')
| -rw-r--r-- | board/reef/gpio.inc | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/board/reef/gpio.inc b/board/reef/gpio.inc index b1421d6e05..ffba5edbae 100644 --- a/board/reef/gpio.inc +++ b/board/reef/gpio.inc @@ -9,12 +9,17 @@ * Note: Those with interrupt handlers must be declared first. */ GPIO_INT(CHARGER_INT_L, PIN(3, 3), GPIO_INT_FALLING, bd99955_vbus_interrupt) /* CHARGER_EC_INT_ODL from BD99955 */ +/* + * TODO: The pull ups for Parade TCPC interrupt line can be removed in versions + * of board following EVT in which daughter card (which has an external pull up) + * will always be inserted. + */ #if IS_PROTO == 1 GPIO_INT(USB_C0_PD_INT_ODL, PIN(3, 7), GPIO_INT_RISING, tcpc_alert_event) /* from Analogix TCPC */ -GPIO_INT(USB_C1_PD_INT_ODL, PIN(D, 2), GPIO_INT_FALLING, tcpc_alert_event) /* from Parade TCPC */ +GPIO_INT(USB_C1_PD_INT_ODL, PIN(D, 2), GPIO_INT_FALLING | GPIO_PULL_UP, tcpc_alert_event) /* from Parade TCPC */ #else GPIO_INT(USB_C0_PD_INT_ODL, PIN(3, 7), GPIO_INT_FALLING, tcpc_alert_event) /* from Analogix TCPC */ -GPIO_INT(USB_C1_PD_INT_ODL, PIN(B, 1), GPIO_INT_FALLING, tcpc_alert_event) /* from Parade TCPC */ +GPIO_INT(USB_C1_PD_INT_ODL, PIN(B, 1), GPIO_INT_FALLING | GPIO_PULL_UP, tcpc_alert_event) /* from Parade TCPC */ #endif GPIO_INT(PCH_SLP_S4_L, PIN(8, 6), GPIO_INT_BOTH, power_signal_interrupt) /* SLP_S4_L */ |