diff options
| author | Gwendal Grignou <gwendal@chromium.org> | 2019-03-11 15:57:52 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-26 04:42:55 -0700 |
| commit | bb266fc26fc05d4ab22de6ad7bce5b477c9f9140 (patch) | |
| tree | f6ada087f62246c3a9547e649ac8846b0ed6d5ab /board/samus | |
| parent | 0bfc511527cf2aebfa163c63a1d028419ca0b0c3 (diff) | |
| download | chrome-ec-bb266fc26fc05d4ab22de6ad7bce5b477c9f9140.tar.gz | |
common: replace 1 << digits, with BIT(digits)
Requested for linux integration, use BIT instead of 1 <<
First step replace bit operation with operand containing only digits.
Fix an error in motion_lid try to set bit 31 of a signed integer.
BUG=None
BRANCH=None
TEST=compile
Change-Id: Ie843611f2f68e241f0f40d4067f7ade726951d29
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1518659
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'board/samus')
| -rw-r--r-- | board/samus/board.c | 2 | ||||
| -rw-r--r-- | board/samus/board.h | 4 | ||||
| -rw-r--r-- | board/samus/panel.c | 6 |
3 files changed, 6 insertions, 6 deletions
diff --git a/board/samus/board.c b/board/samus/board.c index b8f66ca101..9f5bcf743a 100644 --- a/board/samus/board.c +++ b/board/samus/board.c @@ -87,7 +87,7 @@ const struct adc_t adc_channels[] = { * now. */ {"BatteryTemp", LM4_ADC_SEQ2, 1, 1, 0, - LM4_AIN(10), 0x06 /* IE0 | END0 */, LM4_GPIO_B, (1<<4)}, + LM4_AIN(10), 0x06 /* IE0 | END0 */, LM4_GPIO_B, BIT(4)}, }; BUILD_ASSERT(ARRAY_SIZE(adc_channels) == ADC_CH_COUNT); diff --git a/board/samus/board.h b/board/samus/board.h index 59c3e8ca4d..ac76ff0d4c 100644 --- a/board/samus/board.h +++ b/board/samus/board.h @@ -202,8 +202,8 @@ void bkboost_det_interrupt(enum gpio_signal signal); void jtag_interrupt(enum gpio_signal signal); /* Bit masks for turning on PP5000 rail in G3 */ -#define PP5000_IN_G3_AC (1 << 0) -#define PP5000_IN_G3_LIGHTBAR (1 << 1) +#define PP5000_IN_G3_AC BIT(0) +#define PP5000_IN_G3_LIGHTBAR BIT(1) /* Enable/disable PP5000 rail mask in G3 */ void set_pp5000_in_g3(int mask, int enable); diff --git a/board/samus/panel.c b/board/samus/panel.c index 970197b9c8..961cb6fafe 100644 --- a/board/samus/panel.c +++ b/board/samus/panel.c @@ -35,7 +35,7 @@ #define LP8555_REG_CURRENT_MAXCURR_50MA 0x07 #define LP8555_REG_STEP 0x15 #define LP8555_REG_STEP_STEP_0MS (0 << 0) -#define LP8555_REG_STEP_STEP_8MS (1 << 0) +#define LP8555_REG_STEP_STEP_8MS BIT(0) #define LP8555_REG_STEP_STEP_16MS (2 << 0) #define LP8555_REG_STEP_STEP_24MS (3 << 0) #define LP8555_REG_STEP_STEP_28MS (4 << 0) @@ -43,7 +43,7 @@ #define LP8555_REG_STEP_STEP_100MS (6 << 0) #define LP8555_REG_STEP_STEP_200MS (7 << 0) #define LP8555_REG_STEP_PWM_IN_HYST_NONE (0 << 3) -#define LP8555_REG_STEP_PWM_IN_HYST_1LSB (1 << 3) +#define LP8555_REG_STEP_PWM_IN_HYST_1LSB BIT(3) #define LP8555_REG_STEP_PWM_IN_HYST_2LSB (2 << 3) #define LP8555_REG_STEP_PWM_IN_HYST_4LSB (3 << 3) #define LP8555_REG_STEP_PWM_IN_HYST_8LSB (4 << 3) @@ -51,7 +51,7 @@ #define LP8555_REG_STEP_PWM_IN_HYST_32LSB (6 << 3) #define LP8555_REG_STEP_PWM_IN_HYST_64LSB (7 << 3) #define LP8555_REG_STEP_SMOOTH_NONE (0 << 6) -#define LP8555_REG_STEP_SMOOTH_LIGHT (1 << 6) +#define LP8555_REG_STEP_SMOOTH_LIGHT BIT(6) #define LP8555_REG_STEP_SMOOTH_MEDIUM (2 << 6) #define LP8555_REG_STEP_SMOOTH_HEAVY (3 << 6) |