diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2015-07-14 15:06:21 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-08-01 02:52:37 +0000 |
| commit | d74949e3e68c000ead762d5acf42a5e967d2d976 (patch) | |
| tree | ba38ef96120726a6ae786df5666025f9dc7c8c9f /board/samus_pd | |
| parent | e2f233faafe2b7932fad0f03ef2ecd73c0b8abef (diff) | |
| download | chrome-ec-d74949e3e68c000ead762d5acf42a5e967d2d976.tar.gz | |
tasks: Remove most task_start_called() calls.
Now that HOOK_INIT hooks are called from a task switching context, most
calls to task_start_called() should no longer be needed. This commit
removes them.
BRANCH=None
BUG=chrome-os-partner:27226
TEST=make -j buildall tests
TEST=Flash EC image onto samus and verify EC boot, AP boot, keyboard,
lid, and tap-for-battery all functional.
TEST=Flash EC image onto samus_pd and verify charging still works.
TEST=Flash EC image onto ryu(P3) and verify that EC boot.
TEST=Added ASSERT(task_start_called()) to the places where I removed
task_start_called(). Booted samus, samus_pd, cyan, and ryu with AC
inserted and verified that no ASSERT's were hit upon boot.
Change-Id: Ic12c61862e85ca3a0a295beedbb4eeee6d5e515b
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/285635
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Trybot-Ready: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'board/samus_pd')
| -rw-r--r-- | board/samus_pd/board.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/board/samus_pd/board.c b/board/samus_pd/board.c index d7c2c8b6e8..dcf40cdd99 100644 --- a/board/samus_pd/board.c +++ b/board/samus_pd/board.c @@ -129,8 +129,7 @@ void vbus0_evt(enum gpio_signal signal) * these unwanted resets. */ hook_call_deferred(pericom_port0_reenable_interrupts, 0); - if (task_start_called()) - task_wake(TASK_ID_PD_C0); + task_wake(TASK_ID_PD_C0); } void vbus1_evt(enum gpio_signal signal) @@ -155,8 +154,7 @@ void vbus1_evt(enum gpio_signal signal) * these unwanted resets. */ hook_call_deferred(pericom_port1_reenable_interrupts, 0); - if (task_start_called()) - task_wake(TASK_ID_PD_C1); + task_wake(TASK_ID_PD_C1); } static void wake_usb_charger_task(int port) |