diff options
author | CHLin <CHLIN56@nuvoton.com> | 2017-07-28 10:22:32 +0800 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2017-07-31 19:21:07 -0700 |
commit | ddbfe690e294e595c6ed3511dcf417410d9b2804 (patch) | |
tree | 775252a42740b33ed34be2952fe9379a5838980f /board/servo_v4/board.c | |
parent | 553d00bdb4e55fdfc5cc75772f686e20cd764c3e (diff) | |
download | chrome-ec-ddbfe690e294e595c6ed3511dcf417410d9b2804.tar.gz |
npcx: workaround the bug that SHM data read via eSPI may be corrupted
In eSPI systems, when the Host performs a data read from the Shared
Memory space, the returned data may be corrupted. This is a result of
the Core-to-Host access enable bit being toggled (by toggling CSAE bit
in SIBCTRL register) during an eSPI transaction.
The workaround in this CL is to set CSAE bit to 1 during initialization
and remove the toggling of CSAE bit from other EC firmware code.
(i.e., let the CSAE bit be always 1.)
BRANCH=none
BUG=none
TEST=No build errors for make buildall. Flash poppy ec image, make sure
it can boot to OS. Run "ectool version" over 100000 times, no error
occurs.
Change-Id: I7aac6805ece64e8f77964d4acb026d9871cd2ebe
Signed-off-by: CHLin <CHLIN56@nuvoton.com>
Reviewed-on: https://chromium-review.googlesource.com/590396
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: CH Lin <chlin56@nuvoton.com>
Reviewed-by: Shawn N <shawnn@chromium.org>
Diffstat (limited to 'board/servo_v4/board.c')
0 files changed, 0 insertions, 0 deletions