diff options
| author | Scott <scollyer@chromium.org> | 2017-02-02 19:42:32 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-02-06 14:50:31 -0800 |
| commit | 2e0df8b6c66c2150dbac853a1abe67d41e46acf9 (patch) | |
| tree | 571e3e40336f50a6e45648d42725a3a15e629691 /board/servo_v4 | |
| parent | a3b0d7c8979fab5e3fe7f0151ff5d3e221e6531b (diff) | |
| download | chrome-ec-2e0df8b6c66c2150dbac853a1abe67d41e46acf9.tar.gz | |
cr50: Have INAs and I2Cm enabled when rdd is attached
The INAs are only used for development and testing
purposes. Therefore, the 3.3V rail to the INAs is off by default and
the I2Cm module is not enabled. Enabling INA power and connecting the
I2Cm module was done at the beginning of each USB to I2C request. The
problem with this approach is that INA measurments didn't always
succeed due to not enough time for the INAs to initialize.
Rather than add some arbitrary delay, it is better to tie the INAs to
when rdd is attached/detached. It is only when rdd is attached that
the INAs will be accessed, so there is no need to enable/disable for
each individual I2C transaction.
This CL ties the enabling/disabling of the INA and I2Cm module to the
rdd state. This change makes the previous use of
usb_i2c_board_enable() and usb_i2c_board_disable() obslete.
BRANCH=none
BUG=chrome-os-partner:62375
TEST=manual
Connect servo with suzyq connected:
sudo servod -p 0x5014 -b eve -c eve_r0_inas.xml
Then execute single INA reads dut-control pp3300_dx_edp_mv and verify
that it returns meaningful numbers. Without this CL single reads via
dut-control would always return 0.
Change-Id: I799552bfd0701efd1828a0d720ac2a6cedee5ca1
Signed-off-by: Scott <scollyer@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/436864
Commit-Ready: Scott Collyer <scollyer@chromium.org>
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Diffstat (limited to 'board/servo_v4')
| -rw-r--r-- | board/servo_v4/board.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/board/servo_v4/board.c b/board/servo_v4/board.c index 99a0fa1500..b12126c7d8 100644 --- a/board/servo_v4/board.c +++ b/board/servo_v4/board.c @@ -237,9 +237,6 @@ const struct i2c_port_t i2c_ports[] = { }; const unsigned int i2c_ports_used = ARRAY_SIZE(i2c_ports); -int usb_i2c_board_enable(void) {return EC_SUCCESS; } -void usb_i2c_board_disable(int debounce) {} - /****************************************************************************** * Support firmware upgrade over USB. We can update whichever section is not |