diff options
| author | Jan Dabros <jsd@semihalf.com> | 2021-02-16 12:07:46 +0100 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-02-17 14:47:50 +0000 |
| commit | a6c856587d102780215243a640284a1c6e16746e (patch) | |
| tree | 6ba10718d9157dab38dcc869349356226641dc7c /board/servo_v4p1/board.c | |
| parent | 5ca648a60bd07355ad98ab428e90b8fd306e5a8b (diff) | |
| download | chrome-ec-a6c856587d102780215243a640284a1c6e16746e.tar.gz | |
Revert "servo_v4p1: Add driver for power management"
This reverts commit 4f8c2db072fb4a8a99ccdc9fa557f122582f8173.
servo_v4p1 uses charge_manager, however currently this is done
improperly. Instead of HOST and ALT ports, CHG and DUT ports are
registered withing framework, even though they are not used for charging
servo platform itself.
In order to implement power management, the most convenient (and clean)
solution is to use charge_manager API. The plan is to make use of it,
however first we need to address charge_manager problem mentioned above.
This way we will avoid code duplication and custom drivers which
duplicate existing generic implementation.
For the time being, revert custom power management. After fix for
charge_manager on servo_v4p1 is applied, will get back to this issue and
re-apply power management features in new form.
BUG=b:144776402
BRANCH=main
TEST=build and flash servo_v4p1. After it boots, issue `ina 2` command.
By default the Alert limit should be equal to 0, which means that now
power restrictions are applied.
Signed-off-by: Jan Dabros <jsd@semihalf.com>
Change-Id: I8aea351331dd380fc13c5c6c43ea7dc3a29bd918
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2697070
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'board/servo_v4p1/board.c')
| -rw-r--r-- | board/servo_v4p1/board.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/board/servo_v4p1/board.c b/board/servo_v4p1/board.c index b189948ff6..df932517ff 100644 --- a/board/servo_v4p1/board.c +++ b/board/servo_v4p1/board.c @@ -21,7 +21,6 @@ #include "ioexpanders.h" #include "pathsel.h" #include "pi3usb9201.h" -#include "power_mgmt.h" #include "queue_policies.h" #include "registers.h" #include "spi.h" @@ -429,8 +428,6 @@ static void evaluate_input_power_def(void) gl3590_init(HOST_HUB); - evaluate_input_power(); - init_uservo_port(); init_pathsel(); } |