diff options
| author | Brian Nemec <bnemec@chromium.org> | 2020-09-24 20:56:45 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-09-28 21:49:54 +0000 |
| commit | 10782c7c87b2d1a702375fb4394d19d5216febd8 (patch) | |
| tree | 0f6791e5e2279b218822fe67823326dfc244ae4d /board/servo_v4p1/ioexpanders.c | |
| parent | b2af3aaad8b19b4facaa2fb8f06436f3a214fdba (diff) | |
| download | chrome-ec-10782c7c87b2d1a702375fb4394d19d5216febd8.tar.gz | |
Revert "ServoV4/V4p1: Change CCD detection flow"
This reverts commit 1a09ade7b846cc048fb2f177adcacd5f836b8887.
Reason for revert: b:167734179 CCD detection is failing on many devices. Tests on reverted devices show this is primary cause.
Original change's description:
> ServoV4/V4p1: Change CCD detection flow
>
> Currently, servoV4 and servoV4p1 don't apply terminations to SBU when
> searching for a DUT. This means SBU can float which can break the SBU
> voltage detection. Technically, the DUT should only need to pull up D+
> and can float D- since it is a FS USB2 device when in CCD mode.
>
> Change the detection to connect SBU to the USB2 hub on servoV4/4p1. The
> USB2 hub will apply 15k pulldowns to the USB lines, which will pull SBU
> down and fix detection in the case where the DUT floats SBU.
>
> BUG=b:161762948, b:150886157, b:151487379
> TEST=make BOARD=servo_v4; make BOARD=servo_v4p1
> TEST=check that CCD works on DUT without pulldown resistors on SBU
> BRANCH=none
>
> Change-Id: I9b6f620617fb0e270e35804704111afd3c606a3b
> Signed-off-by: Eric Herrmann <eherrmann@chromium.org>
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2352439
> Reviewed-by: Wai-Hong Tam <waihong@google.com>
BUG=b:167734179, b:168546666, b:168548776
TEST=Measured SBU voltages with the prior CL included, observed
low voltages and no-voltage on some platforms including variations
of dedede under the flipped orientation.
TEST=Reverted the CL and CCD detection worked reliably,
devices with CCD not driving SBU rails started working, and
labstation release was more reliable on prior versions.
Change-Id: Iaecd7371164804ce09a7fd19ac8fd1f44d93aef2
Signed-off-by: Brian Nemec <bnemec@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2429496
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Reviewed-by: Eric Herrmann <eherrmann@chromium.org>
Diffstat (limited to 'board/servo_v4p1/ioexpanders.c')
| -rw-r--r-- | board/servo_v4p1/ioexpanders.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/board/servo_v4p1/ioexpanders.c b/board/servo_v4p1/ioexpanders.c index 9c88d7a2d0..6617a8d30e 100644 --- a/board/servo_v4p1/ioexpanders.c +++ b/board/servo_v4p1/ioexpanders.c @@ -26,14 +26,14 @@ int init_ioexpanders(void) * ------------------------------------------------- * BIT-0 (SBU_UART_SEL) | O | 0 * BIT-1 (ATMEL_RESET_L) | O | 0 - * BIT-2 (SBU_FLIP_SEL) | O | 0 + * BIT-2 (SBU_FLIP_SEL) | O | 1 * BIT-3 (USB3_A0_MUX_SEL) | O | 0 * BIT-4 (USB3_A0_MUX_EN_L) | O | 0 * BIT-5 (USB3_A0_PWR_EN) | O | 0 * BIT-6 (UART_18_SEL) | O | 0 * BIT-7 (USERVO_POWER_EN) | O | 0 */ - ret = tca6416a_write_byte(1, TCA6416A_OUT_PORT_0, 0x00); + ret = tca6416a_write_byte(1, TCA6416A_OUT_PORT_0, 0x04); if (ret != EC_SUCCESS) return ret; |