diff options
| author | Randall Spangler <rspangler@chromium.org> | 2013-04-12 15:07:58 -0700 |
|---|---|---|
| committer | ChromeBot <chrome-bot@google.com> | 2013-04-15 14:27:45 -0700 |
| commit | 108235225d2536f75a3100cd535f44f732b486c3 (patch) | |
| tree | 3f111879d86eddbc6979af513ed466dc20faf13d /board/snow | |
| parent | 27459f8600d76d5a7ccc4cc1c396ef59cb26ff19 (diff) | |
| download | chrome-ec-108235225d2536f75a3100cd535f44f732b486c3.tar.gz | |
Refactor gpio_set_level() and gpio_pre_init()
gpio_set_level() now allows setting the pin level if GPIO_LOW or
GPIO_HIGH is specified. Previously, stm32 platforms did this even
though the definition of gpio_set_level() said it wouldn't work.
Fixed gpio_set_level() not setting level after warm reboot on stm32
because it was checking the GPIO_DEFAULT flag in the wrong place.
Fixed LM4 still mucking with alternate function settings and levels
even if GPIO_DEFAULT was specified.
And checked gpio_list[] and all of the calls to gpio_set_flags() to
make sure everything still behaves the same way it did before (or
better, in the case of actual bugs).
BUG=chrome-os-partner:18718
BRANCH=none
TEST=build all platforms; boot spring and link
Change-Id: I4b84815f76060252df235ff9a37da52c54a8eac5
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/48058
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Diffstat (limited to 'board/snow')
| -rw-r--r-- | board/snow/board.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/snow/board.c b/board/snow/board.c index aaca03f7fd..4df97cd617 100644 --- a/board/snow/board.c +++ b/board/snow/board.c @@ -22,7 +22,7 @@ #include "util.h" #define GPIO_KB_INPUT (GPIO_INPUT | GPIO_PULL_UP | GPIO_INT_BOTH) -#define GPIO_KB_OUTPUT (GPIO_OUTPUT | GPIO_OPEN_DRAIN) +#define GPIO_KB_OUTPUT GPIO_HI_Z #define INT_BOTH_FLOATING (GPIO_INPUT | GPIO_INT_BOTH) #define INT_BOTH_PULL_UP (GPIO_INPUT | GPIO_PULL_UP | GPIO_INT_BOTH) |