diff options
author | Keith Short <keithshort@chromium.org> | 2020-03-04 12:53:25 -0700 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2020-04-09 00:56:31 +0000 |
commit | 3b831bbf6ee24a09ef65064d7374e6ef7960eedf (patch) | |
tree | 1e60e398e159b257a3cba56bc037844d0b289d84 /board/volteer | |
parent | 4d39614441258dc5788c2a55000abe56ac43d3fe (diff) | |
download | chrome-ec-3b831bbf6ee24a09ef65064d7374e6ef7960eedf.tar.gz |
icelake: Cleanup power sequencing for IceLake/TigerLake/JasperLake
Configure PWROK generation related signals for Ice Lake, Tiger Lake, and
Jasper Lake SoCs. The array driven sequencing provides better
flexibility for the PWROK signals, some of which may be automatically
handled by the platform and some require EC control.
BUG=b:150726713
BRANCH=none
TEST=make buildall
TEST=Volteer: verify VCCIN enable and SYS_PWROK generation during S0 and
verify signals are deasserted when exiting S0.
TEST=Wadledoo: verified 2ms delay between ALL_SYS_PWRGD and PCH_PWROK,
verified JPL sequences to S0.
Change-Id: Iceae29c65398643839b31f6cd757352282849fda
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2088285
Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'board/volteer')
-rw-r--r-- | board/volteer/board.h | 1 | ||||
-rw-r--r-- | board/volteer/gpio.inc | 1 |
2 files changed, 1 insertions, 1 deletions
diff --git a/board/volteer/board.h b/board/volteer/board.h index 8ebc01ede8..3c7bd930a9 100644 --- a/board/volteer/board.h +++ b/board/volteer/board.h @@ -72,7 +72,6 @@ #define GPIO_PCH_PWRBTN_L GPIO_EC_PCH_PWR_BTN_ODL #define GPIO_PCH_RSMRST_L GPIO_EC_PCH_RSMRST_ODL #define GPIO_PCH_RTCRST GPIO_EC_PCH_RTCRST -#define GPIO_PCH_SYS_PWROK GPIO_EC_PCH_SYS_PWROK #define GPIO_PCH_SLP_S0_L GPIO_SLP_S0_L #define GPIO_PCH_SLP_S3_L GPIO_SLP_S3_L #define GPIO_PG_EC_DSW_PWROK GPIO_DSW_PWROK diff --git a/board/volteer/gpio.inc b/board/volteer/gpio.inc index 73634db510..ce1c1eae43 100644 --- a/board/volteer/gpio.inc +++ b/board/volteer/gpio.inc @@ -60,6 +60,7 @@ GPIO_INT(EC_VOLUP_BTN_ODL, PIN(9, 7), GPIO_INT_BOTH | GPIO_PULL_UP, button_inte /* Power Sequencing Signals */ GPIO(EN_PP3300_A, PIN(A, 3), GPIO_OUT_LOW) GPIO(EN_PP5000_A, PIN(A, 4), GPIO_OUT_LOW) +GPIO(EN_PPVAR_VCCIN, PIN(4, 3), GPIO_OUT_LOW) /* Enables VCCIN IMPV9 */ /* The EC does not buffer this signal on Volteer. */ UNIMPLEMENTED(PCH_DSW_PWROK) |