diff options
| author | Ben Chen <ben.chen2@quanta.corp-partner.google.com> | 2020-12-01 16:26:27 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-12-07 03:01:03 +0000 |
| commit | 1df0d9f61ff348d0928cb268331111b3e887ab3f (patch) | |
| tree | 47993233f1df88385c24d9c1ae8acc5657ed577f /board/voxel | |
| parent | 12525b726691d11287b33ad8b424eccd8ce4c698 (diff) | |
| download | chrome-ec-1df0d9f61ff348d0928cb268331111b3e887ab3f.tar.gz | |
voxel: disable CONFIG_KEYBOARD_VIVALDI
Disable Vivaldi keyboard since Vivaldi currently does not
allow for side volume buttons to be distinguished from
keyboard volume F9/F10 keys. This is necessary so that Chrome
can ignore F9/F10 in tablet mode, but side volume buttons still work.
BUG=b:173147060
BRANCH=master
TEST=make -j BOARD=voxel
TEST=make buildall
TEST=test on voxel, side-buttons work in clamshell/tablet mode
and that F9/F10 only work in clamshell.
Change-Id: I6bcc07ede9e88a82c44642493037eca81936f98f
Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2573658
Reviewed-by: Keith Short <keithshort@chromium.org>
Diffstat (limited to 'board/voxel')
| -rw-r--r-- | board/voxel/board.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/board/voxel/board.h b/board/voxel/board.h index feb39136f3..88b03a3ee6 100644 --- a/board/voxel/board.h +++ b/board/voxel/board.h @@ -37,6 +37,12 @@ #define CONFIG_LED_ONOFF_STATES /* Keyboard features */ +/* + * Disable VOL up/down when tablet mode. + * TODO(b/170966461): Re-enable Vivaldi keyboard once + * 8042 and MKBP drivers can coexist. + */ +#undef CONFIG_KEYBOARD_VIVALDI /* Sensors */ /* BMI160 Base accel/gyro */ |