diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2020-09-11 20:37:26 -0700 |
|---|---|---|
| committer | Justin TerAvest <teravest@chromium.org> | 2020-09-28 20:25:07 +0000 |
| commit | 605ab1815625e377c902f4047a42e23ddd45debb (patch) | |
| tree | b36391009f6983cc952d20bc06325077a3359305 /board/waddledee | |
| parent | d617485fa3802f2f72dcefecb5d4dcbbc20b3abc (diff) | |
| download | chrome-ec-605ab1815625e377c902f4047a42e23ddd45debb.tar.gz | |
waddledee: Update OCPC PID constants
This commit updates the PID constants for waddledee after having
switched to forcing the BFET on instead of using linear mode for the
majority of the charge curve.
BUG=b:168253008
BRANCH=None
TEST=Build and flash waddledee, verify that charging from the sub
board is working and converges without significant oscillation.
Change-Id: Ia55d7b693c4e0745fc4bec94c96595c81995be3c
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2407018
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Diffstat (limited to 'board/waddledee')
| -rw-r--r-- | board/waddledee/board.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/board/waddledee/board.c b/board/waddledee/board.c index 213a93295b..b85ce0cd97 100644 --- a/board/waddledee/board.c +++ b/board/waddledee/board.c @@ -408,14 +408,14 @@ __override void ocpc_get_pid_constants(int *kp, int *kp_div, int *ki, int *ki_div, int *kd, int *kd_div) { - *kp = 1; - *kp_div = 6; + *kp = 3; + *kp_div = 14; - *ki = 0; - *ki_div = 1; + *ki = 3; + *ki_div = 500; - *kd = 0; - *kd_div = 1; + *kd = 4; + *kd_div = 40; } __override void typec_set_source_current_limit(int port, enum tcpc_rp_value rp) |