diff options
author | Shawn Nematbakhsh <shawnn@chromium.org> | 2016-01-21 14:37:53 -0800 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2016-01-25 19:48:21 -0800 |
commit | 8c9210b81e83c94d9d34497d202476c4fa6fb34b (patch) | |
tree | 62736db763a94b69d81a4cd2a6f814fe72ba28ac /board/wheatley | |
parent | f5e9dbe10688cea2d5426c96e3a8976efb22a8a7 (diff) | |
download | chrome-ec-8c9210b81e83c94d9d34497d202476c4fa6fb34b.tar.gz |
mec1322: hibernate: Don't reconfigure all GPIOs
Configuring all GPIOs to INPUT / PULL_UP in hibernate is not a good
idea:
- INPUT / PULL_UP is not necessarially the lowest-power state (for
example, if there is an onboard pull-down).
- Most GPIOs should already be in lowest-power state when we're in S5.
- For the few GPIOs that need to be in a different state for hibernate,
we can use a board-level callback.
In addition, remove mec1322 code related to restoring from hibernate
state, since we always reset coming out of hibernate.
BUG=chrome-os-partner:49608
BRANCH=glados, strago
TEST=`hibernate` on chell console when in S5 and AC removed. Verify that
EC power is roughly equivalent to low-power idle power. Attach Zinger,
verify that device wakes and boots, and charges from charger.
Change-Id: Ib00ef035bec32cea3847eb38d743f5c0cec896ca
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/322937
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>
Diffstat (limited to 'board/wheatley')
-rw-r--r-- | board/wheatley/board.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/wheatley/board.c b/board/wheatley/board.c index 143642c3e0..8fcd142efa 100644 --- a/board/wheatley/board.c +++ b/board/wheatley/board.c @@ -379,7 +379,7 @@ static void board_chipset_suspend(void) } DECLARE_HOOK(HOOK_CHIPSET_SUSPEND, board_chipset_suspend, HOOK_PRIO_DEFAULT); -void board_set_gpio_state_hibernate(void) +void board_set_gpio_hibernate_state(void) { int i; const uint32_t hibernate_pins[][2] = { |