diff options
| author | Furquan Shaikh <furquan@google.com> | 2018-04-18 23:48:18 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-04-19 19:28:44 -0700 |
| commit | 91148de7c836a382e3433e6a7a1d8adc48148799 (patch) | |
| tree | fbf7138b447f3cb2990da0a8d4c644d40faad5fc /board/yorp/board.c | |
| parent | 277d59a36c0ecc80db9a5e4097c05c33c0bc30b7 (diff) | |
| download | chrome-ec-91148de7c836a382e3433e6a7a1d8adc48148799.tar.gz | |
APL/GLK: Move chipset shutdown to chipset task
In order to ensure that all chipset init/shutdown operations happen
within the context of chipset task for APL/GLK:
1. Update chipset_force_shutdown to only set a flag force_shutdown to
indicate that chipset shutdown is requested and wake the chipset task.
2. Make chipset task (within the power state machine) call
internal_chipset_shutdown.
3. Make internal_chipset_shutdown reset force_shutdown flag and make a
callback to weak function chipset_do_shutdown to trigger chipset
shutdown.
BUG=b:78259506
BRANCH=None
TEST=Verified that "apshutdown" on EC console results in chipset
shutdown action being taken within chipset task.
Change-Id: If13b65ae47e3dce2e466320cc14c68239563f6ed
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1018737
Commit-Ready: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'board/yorp/board.c')
| -rw-r--r-- | board/yorp/board.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/board/yorp/board.c b/board/yorp/board.c index ca130bdb47..a0c7b1fd81 100644 --- a/board/yorp/board.c +++ b/board/yorp/board.c @@ -167,9 +167,8 @@ void chipset_do_shutdown(void) gpio_set_level(GPIO_PMIC_EN, 0); /* Disable 5.0V and 3.3V rails, and wait until they power down. */ -#ifdef HAS_TASK_CHIPSET power_5v_enable(task_get_current(), 0); -#endif + /* * Shutdown the 3.3V rail and wait for it to go down. We cannot wait * for the 5V rail since other tasks may be using it. |