Clean up debug config options

All of these were defined on all but a few platforms, and those
explicitly #undef them.  So define them as enabled by default in
config.h so the board.h files are cleaner.

No functional changes; just rearranging/renaming config constants.

BUG=chrome-os-partner:18343
BRANCH=none
TEST=build all platforms; FEATURES=test emerge-falco chromeos-ec

Change-Id: I1201a1472ae29641e9e219c2a0347691ca64cd28
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/63102
Reviewed-by: Vic Yang <victoryang@chromium.org>

13 files changed, 1 insertions, 61 deletions

diff --git a/board/bds/board.h b/board/bds/board.h
index 00127fd8c0..98b0945515 100644
--- a/board/bds/board.h
+++ b/board/bds/board.h
@@ -8,12 +8,7 @@
 #ifndef __BOARD_H
 #define __BOARD_H
 
-/* Debug features */
-#define CONFIG_PANIC_HELP
-#define CONFIG_ASSERT_HELP
-
 /* Optional features */
-#define CONFIG_CONSOLE_CMDHELP
 #define CONFIG_SYSTEM_UNLOCKED  /* Allow dangerous commands */
 
 /* LM4 modules we don't use on link but still want to keep compiling */
diff --git a/board/daisy/board.h b/board/daisy/board.h
index 2c8d0db1e3..681d09a345 100644
--- a/board/daisy/board.h
+++ b/board/daisy/board.h
@@ -14,10 +14,6 @@
 /* Use USART1 as console serial port */
 #define CONFIG_CONSOLE_UART 1
 
-/* Debug features */
-#define CONFIG_PANIC_HELP
-#define CONFIG_ASSERT_HELP
-
 /* Optional features */
 #define CONFIG_BATTERY_SMART
 #define CONFIG_BOARD_POST_GPIO_INIT
diff --git a/board/falco/board.h b/board/falco/board.h
index 37a923e43e..d3c5dfd215 100644
--- a/board/falco/board.h
+++ b/board/falco/board.h
@@ -8,12 +8,6 @@
 #ifndef __BOARD_H
 #define __BOARD_H
 
-/* Debug features */
-#define CONFIG_ASSERT_HELP
-#define CONFIG_CONSOLE_CMDHELP
-#define CONFIG_PANIC_HELP
-#define CONFIG_TASK_PROFILING
-
 /* Optional features */
 #define CONFIG_BACKLIGHT_X86
 #define CONFIG_BATTERY_FALCO
diff --git a/board/host/board.h b/board/host/board.h
index 7ef70bd3a7..e9d0e3adbe 100644
--- a/board/host/board.h
+++ b/board/host/board.h
@@ -8,10 +8,6 @@
 #ifndef __BOARD_H
 #define __BOARD_H
 
-/* Assertion support */
-#define CONFIG_DEBUG
-#define CONFIG_ASSERT_HELP
-
 /* Optional features */
 #define CONFIG_EXTPOWER_GPIO
 #define CONFIG_HOSTCMD
diff --git a/board/link/board.h b/board/link/board.h
index 485979153f..a84bf1f8a1 100644
--- a/board/link/board.h
+++ b/board/link/board.h
@@ -8,12 +8,6 @@
 #ifndef __BOARD_H
 #define __BOARD_H
 
-/* Debug features */
-#define CONFIG_ASSERT_HELP
-#define CONFIG_CONSOLE_CMDHELP
-#define CONFIG_PANIC_HELP
-#define CONFIG_TASK_PROFILING
-
 /* Optional features */
 #define CONFIG_BACKLIGHT_X86
 #define CONFIG_BATTERY_LINK
diff --git a/board/mccroskey/board.h b/board/mccroskey/board.h
index 6001df7f31..99cfaf6509 100644
--- a/board/mccroskey/board.h
+++ b/board/mccroskey/board.h
@@ -15,10 +15,7 @@
 #define CONFIG_CONSOLE_UART 1
 
 /* Debug features */
-#define CONFIG_ASSERT_HELP
-#define CONFIG_CONSOLE_CMDHELP
-#define CONFIG_DEBUG_I2C	/* FIXME(dhendrix): remove this eventually */
-#define CONFIG_PANIC_HELP
+#define CONFIG_I2C_DEBUG	/* FIXME(dhendrix): remove this eventually */
 #undef  CONFIG_TASK_PROFILING
 #define CONFIG_WATCHDOG_HELP
 
diff --git a/board/peppy/board.h b/board/peppy/board.h
index b47ba2a7ef..3bdd58bd00 100644
--- a/board/peppy/board.h
+++ b/board/peppy/board.h
@@ -8,12 +8,6 @@
 #ifndef __BOARD_H
 #define __BOARD_H
 
-/* Debug features */
-#define CONFIG_ASSERT_HELP
-#define CONFIG_CONSOLE_CMDHELP
-#define CONFIG_PANIC_HELP
-#define CONFIG_TASK_PROFILING
-
 /* Optional features */
 #define CONFIG_BACKLIGHT_X86
 #define CONFIG_BATTERY_CHECK_CONNECTED
diff --git a/board/pit/board.h b/board/pit/board.h
index 7ef77aa2e2..7b1cd08eda 100644
--- a/board/pit/board.h
+++ b/board/pit/board.h
@@ -12,10 +12,6 @@
 #define CONFIG_CONSOLE_UART 1
 
 /* Debug features */
-#define CONFIG_ASSERT_HELP
-#define CONFIG_CONSOLE_CMDHELP
-#define CONFIG_PANIC_HELP
-#define CONFIG_TASK_PROFILING
 #define CONFIG_WATCHDOG_HELP
 
 /* Optional features */
diff --git a/board/puppy/board.h b/board/puppy/board.h
index f4f3b9a90d..1618ce7158 100644
--- a/board/puppy/board.h
+++ b/board/puppy/board.h
@@ -12,10 +12,6 @@
 #define CONFIG_CONSOLE_UART 1
 
 /* Debug features */
-#define CONFIG_ASSERT_HELP
-#define CONFIG_CONSOLE_CMDHELP
-#define CONFIG_PANIC_HELP
-#define CONFIG_TASK_PROFILING
 #define CONFIG_WATCHDOG_HELP
 
 /* Optional features */
diff --git a/board/slippy/board.h b/board/slippy/board.h
index febea388a7..0211f06b1b 100644
--- a/board/slippy/board.h
+++ b/board/slippy/board.h
@@ -8,12 +8,6 @@
 #ifndef __BOARD_H
 #define __BOARD_H
 
-/* Debug features */
-#define CONFIG_ASSERT_HELP
-#define CONFIG_CONSOLE_CMDHELP
-#define CONFIG_PANIC_HELP
-#define CONFIG_TASK_PROFILING
-
 /* Optional features */
 #define CONFIG_BACKLIGHT_X86
 #define CONFIG_BATTERY_CHECK_CONNECTED
diff --git a/board/snow/board.h b/board/snow/board.h
index add3a9a8ef..73b67e3610 100644
--- a/board/snow/board.h
+++ b/board/snow/board.h
@@ -15,9 +15,6 @@
 #define CONFIG_CONSOLE_UART 1
 
 /* Debug features */
-#define CONFIG_ASSERT_HELP
-#define CONFIG_CONSOLE_CMDHELP
-#define CONFIG_PANIC_HELP
 #undef  CONFIG_TASK_PROFILING
 #define CONFIG_WATCHDOG_HELP
 
diff --git a/board/spring/board.h b/board/spring/board.h
index eda82603c8..f919c99987 100644
--- a/board/spring/board.h
+++ b/board/spring/board.h
@@ -16,9 +16,6 @@
 #define CONFIG_CONSOLE_RESTRICTED_INPUT
 
 /* Debug features */
-#define CONFIG_ASSERT_HELP
-#define CONFIG_CONSOLE_CMDHELP
-#define CONFIG_PANIC_HELP
 #undef  CONFIG_TASK_PROFILING
 #define CONFIG_WATCHDOG_HELP
 
diff --git a/board/wolf/board.h b/board/wolf/board.h
index 8386d425b4..90e8f57612 100644
--- a/board/wolf/board.h
+++ b/board/wolf/board.h
@@ -8,12 +8,6 @@
 #ifndef __BOARD_H
 #define __BOARD_H
 
-/* Debug features */
-#define CONFIG_ASSERT_HELP
-#define CONFIG_CONSOLE_CMDHELP
-#define CONFIG_PANIC_HELP
-#define CONFIG_TASK_PROFILING
-
 /* Optional features */
 #define CONFIG_BACKLIGHT_X86
 #ifdef HAS_TASK_CHIPSET