diff options
| author | Dawid Niedzwiecki <dn@semihalf.com> | 2020-09-24 09:20:41 +0200 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-10-06 09:44:48 +0000 |
| commit | 32b7e8875e0a08290168ec7dda040d5a5db513fa (patch) | |
| tree | c1336b4c3c0a5e037618bef1ae944485e3f7840b /board | |
| parent | b536c348359487f0408a17af8d9d506f5a1d18a6 (diff) | |
| download | chrome-ec-32b7e8875e0a08290168ec7dda040d5a5db513fa.tar.gz | |
core: rename atomic_clear to atomic_clear_bits
Change the name of atomic_clear to atomic_clear_bits to make to name more
clear - the function clears only selected bits, but the name may suggest
that it clears the whole variable.
It is done as a part of porting to Zephyr, where atomic_clear zeros the
variable.
BUG=b:169151160
BRANCH=none
TEST=buildall
Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com>
Change-Id: I7b0b47959c6c54af40f61bca8d9baebaa0375970
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2428943
Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'board')
| -rw-r--r-- | board/samus/power_sequence.c | 2 | ||||
| -rw-r--r-- | board/samus_pd/board.c | 4 | ||||
| -rw-r--r-- | board/twinkie/sniffer.c | 5 |
3 files changed, 6 insertions, 5 deletions
diff --git a/board/samus/power_sequence.c b/board/samus/power_sequence.c index be2c9961cd..f6033055c4 100644 --- a/board/samus/power_sequence.c +++ b/board/samus/power_sequence.c @@ -504,7 +504,7 @@ void set_pp5000_in_g3(int mask, int enable) if (enable) deprecated_atomic_or(&pp5000_in_g3, mask); else - deprecated_atomic_clear(&pp5000_in_g3, mask); + deprecated_atomic_clear_bits(&pp5000_in_g3, mask); /* if we are in G3 now, then set the rail accordingly */ if (chipset_in_state(CHIPSET_STATE_HARD_OFF)) diff --git a/board/samus_pd/board.c b/board/samus_pd/board.c index fb98304c80..0f9c8cfbfe 100644 --- a/board/samus_pd/board.c +++ b/board/samus_pd/board.c @@ -593,7 +593,7 @@ static enum ec_status ec_status_host_cmd(struct host_cmd_handler_args *args) r->status = pd_status_flags; /* Clear host event */ - deprecated_atomic_clear(&(pd_status_flags), PD_STATUS_HOST_EVENT); + deprecated_atomic_clear_bits(&(pd_status_flags), PD_STATUS_HOST_EVENT); args->response_size = sizeof(*r); @@ -608,7 +608,7 @@ host_event_status_host_cmd(struct host_cmd_handler_args *args) struct ec_response_host_event_status *r = args->response; /* Clear host event bit to avoid sending more unnecessary events */ - deprecated_atomic_clear(&(pd_status_flags), PD_STATUS_HOST_EVENT); + deprecated_atomic_clear_bits(&(pd_status_flags), PD_STATUS_HOST_EVENT); /* Read and clear the host event status to return to AP */ r->status = deprecated_atomic_read_clear(&(host_event_status_flags)); diff --git a/board/twinkie/sniffer.c b/board/twinkie/sniffer.c index f94028b572..6eb2e0824e 100644 --- a/board/twinkie/sniffer.c +++ b/board/twinkie/sniffer.c @@ -316,9 +316,10 @@ void sniffer_task(void) + (EP_PACKET_HEADER_SIZE>>1))), samples[d >> 4]+off, EP_PAYLOAD_SIZE); - deprecated_atomic_clear((uint32_t *)&free_usb, 1 << u); + deprecated_atomic_clear_bits((uint32_t *)&free_usb, + 1 << u); u = !u; - deprecated_atomic_clear(&filled_dma, 1 << d); + deprecated_atomic_clear_bits(&filled_dma, 1 << d); } led_reset_record(); |