diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2017-09-21 15:48:48 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-10-23 04:28:23 -0700 |
| commit | 3a5d032480c1730f00fa608b2112d61634e1427d (patch) | |
| tree | 979242126b19a1e4df9df2c3c5ec4d6052b6f337 /board | |
| parent | bd73291223f99d9547905a7ae4e37c7340e0ce33 (diff) | |
| download | chrome-ec-3a5d032480c1730f00fa608b2112d61634e1427d.tar.gz | |
zoombini: Add pull downs on the sleep signals.
This is needed to prevent some of the power rails from turning on. They
should be weak enough for the AP to still drive them.
BUG=None
BRANCH=None
TEST=Flash zoombini; Verify that PP3000 is not turned on.
Change-Id: I7aca716dc2497aaa0984a1cd033c1f45f2564bbb
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/677875
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>
Diffstat (limited to 'board')
| -rw-r--r-- | board/zoombini/gpio.inc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/board/zoombini/gpio.inc b/board/zoombini/gpio.inc index 09a90ce00b..2bc00e97b8 100644 --- a/board/zoombini/gpio.inc +++ b/board/zoombini/gpio.inc @@ -18,12 +18,12 @@ GPIO_INT(LID_OPEN, PIN(D, 2), GPIO_INT_BOTH | GPIO_HIB_WAKE_HIGH, lid_int GPIO_INT(AC_PRESENT, PIN(0, 0), GPIO_INT_BOTH | GPIO_HIB_WAKE_HIGH, extpower_interrupt) /* Power Signals. */ -GPIO_INT(PCH_SLP_S0_L, PIN(A, 4), GPIO_INT_BOTH, power_signal_interrupt) +GPIO_INT(PCH_SLP_S0_L, PIN(A, 4), GPIO_INT_BOTH | GPIO_PULL_DOWN, power_signal_interrupt) #ifndef CONFIG_ESPI_VW_SIGNALS -GPIO_INT(PCH_SLP_S3_L, PIN(A, 6), GPIO_INT_BOTH, power_signal_interrupt) -GPIO_INT(PCH_SLP_S4_L, PIN(A, 3), GPIO_INT_BOTH, power_signal_interrupt) +GPIO_INT(PCH_SLP_S3_L, PIN(A, 6), GPIO_INT_BOTH | GPIO_PULL_DOWN, power_signal_interrupt) +GPIO_INT(PCH_SLP_S4_L, PIN(A, 3), GPIO_INT_BOTH | GPIO_PULL_DOWN, power_signal_interrupt) #endif /* defined(CONFIG_ESPI_VW_SIGNALS) */ -GPIO_INT(PCH_SLP_SUS_L, PIN(D, 4), GPIO_INT_BOTH, power_signal_interrupt) +GPIO_INT(PCH_SLP_SUS_L, PIN(D, 4), GPIO_INT_BOTH | GPIO_PULL_DOWN, power_signal_interrupt) /* TODO(aaboagye): Internal PU may be needed later on... */ GPIO_INT(RSMRST_L_PGOOD, PIN(E, 2), GPIO_INT_BOTH, power_signal_interrupt) GPIO_INT(PMIC_DPWROK, PIN(F, 4), GPIO_INT_BOTH, power_signal_interrupt) |