summaryrefslogtreecommitdiff
path: root/board
diff options
context:
space:
mode:
authorTom Hughes <tomhughes@chromium.org>2021-10-15 20:10:00 +0000
committerCommit Bot <commit-bot@chromium.org>2021-11-08 23:04:47 +0000
commit04e6a2380e1cbafb169c7194f0fc58d460193ea6 (patch)
treee745617c2bd08b81de129fa1da176a974fd9e7e1 /board
parentd1378e44168c901e5c5369fb966385da0dd6c259 (diff)
downloadchrome-ec-04e6a2380e1cbafb169c7194f0fc58d460193ea6.tar.gz
tree: Make DECLARE_IRQ routine static
For consistency, make all IRQ handler routines static. BRANCH=none BUG=b:172020503 TEST=make buildall -j Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I43dc4dd0a8cd593d6eb761768acc5c7b6b95e22b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3227265 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'board')
-rw-r--r--board/mchpevb1/board.c2
-rw-r--r--board/twinkie/injector.c2
-rw-r--r--board/twinkie/simpletrace.c4
-rw-r--r--board/twinkie/sniffer.c2
-rw-r--r--board/zinger/board.c2
-rw-r--r--board/zinger/runtime.c2
-rw-r--r--board/zinger/usb_pd_policy.c2
7 files changed, 8 insertions, 8 deletions
diff --git a/board/mchpevb1/board.c b/board/mchpevb1/board.c
index 73cec110bb..aa74d07a0d 100644
--- a/board/mchpevb1/board.c
+++ b/board/mchpevb1/board.c
@@ -975,7 +975,7 @@ DECLARE_HOOK(HOOK_CHIPSET_SHUTDOWN, board_spi_disable,
MOTION_SENSE_HOOK_PRIO + 1);
#ifdef MEC1701_EVB_TACH_TEST /* PWM/TACH test */
-void tach0_isr(void)
+static void tach0_isr(void)
{
MCHP_INT_DISABLE(MCHP_TACH_GIRQ) = MCHP_TACH_GIRQ_BIT(0);
MCHP_INT_SOURCE(MCHP_TACH_GIRQ) = MCHP_TACH_GIRQ_BIT(0);
diff --git a/board/twinkie/injector.c b/board/twinkie/injector.c
index cae1d3557f..ef5bfb3e32 100644
--- a/board/twinkie/injector.c
+++ b/board/twinkie/injector.c
@@ -67,7 +67,7 @@ static const struct res_cfg {
#ifdef HAS_TASK_SNIFFER
/* we don't have the default DMA handlers */
-void dma_event_interrupt_channel_3(void)
+static void dma_event_interrupt_channel_3(void)
{
if (STM32_DMA1_REGS->isr & STM32_DMA_ISR_TCIF(STM32_DMAC_CH3)) {
dma_clear_isr(STM32_DMAC_CH3);
diff --git a/board/twinkie/simpletrace.c b/board/twinkie/simpletrace.c
index 9f151f761f..811bd428fd 100644
--- a/board/twinkie/simpletrace.c
+++ b/board/twinkie/simpletrace.c
@@ -160,11 +160,12 @@ static void print_error(enum pd_rx_errors err)
ccprintf("ERR %d\n", err);
}
+#ifdef HAS_TASK_SNIFFER
/* keep track of RX edge timing in order to trigger receive */
static timestamp_t rx_edge_ts[2][PD_RX_TRANSITION_COUNT];
static int rx_edge_ts_idx[2];
-void rx_event(void)
+static void rx_event(void)
{
int pending, i;
int next_idx;
@@ -209,7 +210,6 @@ void rx_event(void)
}
}
}
-#ifdef HAS_TASK_SNIFFER
DECLARE_IRQ(STM32_IRQ_COMP, rx_event, 1);
#endif
diff --git a/board/twinkie/sniffer.c b/board/twinkie/sniffer.c
index 00effb8539..a567b5d725 100644
--- a/board/twinkie/sniffer.c
+++ b/board/twinkie/sniffer.c
@@ -206,7 +206,7 @@ void tim_rx2_handler(uint32_t stat)
led_set_activity(1);
}
-void tim_dma_handler(void)
+static void tim_dma_handler(void)
{
stm32_dma_regs_t *dma = STM32_DMA1_REGS;
uint32_t stat = dma->isr & (STM32_DMA_ISR_HTIF(DMAC_TIM_RX1)
diff --git a/board/zinger/board.c b/board/zinger/board.c
index 540e615071..38b0227bdf 100644
--- a/board/zinger/board.c
+++ b/board/zinger/board.c
@@ -25,7 +25,7 @@ static uint32_t * const rw_rst =
(uint32_t *)(CONFIG_PROGRAM_MEMORY_BASE+CONFIG_RW_MEM_OFF+4);
/* External interrupt EXTINT7 for external comparator on PA7 */
-void pd_rx_interrupt(void)
+static void pd_rx_interrupt(void)
{
/* trigger reception handling */
pd_rx_handler();
diff --git a/board/zinger/runtime.c b/board/zinger/runtime.c
index cb27cc0f03..0b6f1995f5 100644
--- a/board/zinger/runtime.c
+++ b/board/zinger/runtime.c
@@ -74,7 +74,7 @@ uint32_t task_set_event(task_id_t tskid, uint32_t event)
return 0;
}
-void tim2_interrupt(void)
+static void tim2_interrupt(void)
{
uint32_t stat = STM32_TIM_SR(2);
diff --git a/board/zinger/usb_pd_policy.c b/board/zinger/usb_pd_policy.c
index 098bb13c0f..08314e7aa6 100644
--- a/board/zinger/usb_pd_policy.c
+++ b/board/zinger/usb_pd_policy.c
@@ -393,7 +393,7 @@ int pd_board_checks(void)
}
-void pd_adc_interrupt(void)
+static void pd_adc_interrupt(void)
{
/* Clear flags */
STM32_ADC_ISR = 0x8e;