diff options
author | CHLin <CHLIN56@nuvoton.com> | 2019-04-19 17:47:24 +0800 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2019-04-27 01:36:52 -0700 |
commit | 7a87d4b5c984cc24937944b4cbcd8cd7f3b4fd0b (patch) | |
tree | 7685d1af5f5113570b0d2a3b5eacdb1d01c202dc /board | |
parent | 0c71c4748699f5f2cb1423ffc07d4c852d04b3fc (diff) | |
download | chrome-ec-7a87d4b5c984cc24937944b4cbcd8cd7f3b4fd0b.tar.gz |
npcx: disable the selection of JTAG0 signals due to strap
It was observed that pressing recovery key combination + the other
keys, some keys on the keyboard become invalid after system reboots.
(see b:129908668 for more detail.)
It is because the hardware strap pin for JTAG0 signals is
unintentionally triggered. This CL reverts the selection of JTAG signals
and set them back to keyboard scan function at system initialization.
The revert applies to all real platforms except npcx_evbs.
BRANCH=none
BUG=b:129908668
TEST=pass "make buildall"
TEST=Press the specific key combination, after the system reboots,
the keyboard function works normally. On npcx EVBs, the JTAG0 is still
functional.
Change-Id: I7ede1ea4609466fea50a97b1f60308e4cdfd4544
Signed-off-by: CHLin <CHLIN56@nuvoton.com>
Reviewed-on: https://chromium-review.googlesource.com/1575887
Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: CH Lin <chlin56@nuvoton.com>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'board')
-rw-r--r-- | board/npcx7_evb/board.h | 1 | ||||
-rw-r--r-- | board/npcx_evb/board.h | 1 | ||||
-rw-r--r-- | board/npcx_evb_arm/board.h | 1 |
3 files changed, 3 insertions, 0 deletions
diff --git a/board/npcx7_evb/board.h b/board/npcx7_evb/board.h index 66766934b1..19d07b03ea 100644 --- a/board/npcx7_evb/board.h +++ b/board/npcx7_evb/board.h @@ -31,6 +31,7 @@ #define CONFIG_HOSTCMD_ESPI_VW_SLP_SIGNALS /* Use VW signals instead of GPIOs */ /* Optional features */ +#define CONFIG_ENABLE_JTAG_SELECTION #define CONFIG_BOARD_VERSION_GPIO #define CONFIG_EXTPOWER_GPIO #define CONFIG_I2C_MASTER diff --git a/board/npcx_evb/board.h b/board/npcx_evb/board.h index 59f6add2d4..b74e7cac4f 100644 --- a/board/npcx_evb/board.h +++ b/board/npcx_evb/board.h @@ -30,6 +30,7 @@ #define CONFIG_VBOOT_HASH #define CONFIG_PWM_KBLIGHT #define CONFIG_BOARD_VERSION_GPIO +#define CONFIG_ENABLE_JTAG_SELECTION /* Optional features for test commands */ #define CONFIG_CMD_TASKREADY diff --git a/board/npcx_evb_arm/board.h b/board/npcx_evb_arm/board.h index 0b3ab503e9..5128bffd0a 100644 --- a/board/npcx_evb_arm/board.h +++ b/board/npcx_evb_arm/board.h @@ -27,6 +27,7 @@ #define CONFIG_VBOOT_HASH #define CONFIG_PWM_KBLIGHT #define CONFIG_BOARD_VERSION_GPIO +#define CONFIG_ENABLE_JTAG_SELECTION /* Optional features for test commands */ #define CONFIG_CMD_TASKREADY |