summaryrefslogtreecommitdiff
path: root/board
diff options
context:
space:
mode:
authorSimon Glass <sjg@chromium.org>2023-05-08 15:20:07 -0600
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>2023-05-11 14:04:23 +0000
commit67debcce5555daf1c24e1eada34f7607bf041308 (patch)
tree2ff540cb25f3b08d127d01416f79235eb3022f23 /board
parent7d727e6ec9d487530c909027adcaa0d91c9794d2 (diff)
downloadchrome-ec-67debcce5555daf1c24e1eada34f7607bf041308.tar.gz
charger: Rename enum charge_state to led_pwr_state
This name is confusing, since its members start with PWR_ and the comment for enum charge_state_v2 says that these values are only used to control the LEDs, with one not-quite-correct exception, whatever that might be. We could rename it to power_state, but that is already fairly widely used as a variable in the code base. Also it seems better to match the enum PWR_ prefix. Future work may rename the members too. Rename the charge_state enum. This makes no functional change. BUG=b:218332694 TEST=make buildall Change-Id: If8a7cc73dcfb4c1e89984e57fc55e432416e8aec Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4516187 Commit-Queue: Simon Glass <sjg@chromium.org> Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'board')
-rw-r--r--board/asurada/led.c2
-rw-r--r--board/eve/led.c2
-rw-r--r--board/kakadu/led.c2
-rw-r--r--board/katsu/led.c2
-rw-r--r--board/kukui/led.c4
-rw-r--r--board/nami/led.c2
-rw-r--r--board/nautilus/led.c2
-rw-r--r--board/rammus/led.c2
8 files changed, 9 insertions, 9 deletions
diff --git a/board/asurada/led.c b/board/asurada/led.c
index ca29f0be45..347f526f88 100644
--- a/board/asurada/led.c
+++ b/board/asurada/led.c
@@ -143,7 +143,7 @@ int led_set_brightness(enum ec_led_id led_id, const uint8_t *brightness)
static void update_led(enum ec_led_id led_id, bool is_active_charge_port,
int duty, int tick)
{
- enum charge_state power_state = charge_get_state();
+ enum led_pwr_state power_state = charge_get_state();
if (power_state == PWR_STATE_IDLE) {
/* Factory mode: blinking white (2sec on + 2sec off) */
diff --git a/board/eve/led.c b/board/eve/led.c
index e3dd8c09c4..2b76a15894 100644
--- a/board/eve/led.c
+++ b/board/eve/led.c
@@ -486,7 +486,7 @@ static enum led_pattern led_get_double_tap_pattern(int percent_chg)
static void led_select_pattern(enum led_pattern *pattern_desired, int tap)
{
- enum charge_state chg_state = charge_get_state();
+ enum led_pwr_state chg_state = charge_get_state();
int side;
int percent_chg;
enum led_pattern new_pattern;
diff --git a/board/kakadu/led.c b/board/kakadu/led.c
index 26e1ea22bb..87070bd7af 100644
--- a/board/kakadu/led.c
+++ b/board/kakadu/led.c
@@ -26,7 +26,7 @@ const int supported_led_ids_count = ARRAY_SIZE(supported_led_ids);
static void kakadu_led_set_battery(void)
{
- enum charge_state chstate;
+ enum led_pwr_state chstate;
enum power_state powerstate;
static uint8_t prv_white, prv_amber;
static uint8_t time_cnt;
diff --git a/board/katsu/led.c b/board/katsu/led.c
index 3ce9466613..b925f72574 100644
--- a/board/katsu/led.c
+++ b/board/katsu/led.c
@@ -26,7 +26,7 @@ const int supported_led_ids_count = ARRAY_SIZE(supported_led_ids);
static void katsu_led_set_battery(void)
{
- enum charge_state chstate;
+ enum led_pwr_state chstate;
enum power_state powerstate;
static uint8_t prv_white, prv_amber;
static uint8_t time_cnt;
diff --git a/board/kukui/led.c b/board/kukui/led.c
index 9cfdf855be..f5ddae5c77 100644
--- a/board/kukui/led.c
+++ b/board/kukui/led.c
@@ -15,7 +15,7 @@ const enum ec_led_id supported_led_ids[] = { EC_LED_ID_BATTERY_LED };
const int supported_led_ids_count = ARRAY_SIZE(supported_led_ids);
-static enum charge_state prv_chstate = PWR_STATE_INIT;
+static enum led_pwr_state prv_chstate = PWR_STATE_INIT;
#define LED_OFF MT6370_LED_ID_OFF
#define LED_RED MT6370_LED_ID1
@@ -29,7 +29,7 @@ static enum charge_state prv_chstate = PWR_STATE_INIT;
static void kukui_led_set_battery(void)
{
- enum charge_state chstate;
+ enum led_pwr_state chstate;
static uint8_t prv_r, prv_g, prv_b;
uint8_t br[EC_LED_COLOR_COUNT] = { 0 };
diff --git a/board/nami/led.c b/board/nami/led.c
index a92302b860..53f6bccd07 100644
--- a/board/nami/led.c
+++ b/board/nami/led.c
@@ -504,7 +504,7 @@ void config_leds(enum led_charge_state charge)
static void call_handler(void)
{
int soc;
- enum charge_state cs;
+ enum led_pwr_state cs;
if (!led_auto_control_is_enabled(EC_LED_ID_BATTERY_LED))
return;
diff --git a/board/nautilus/led.c b/board/nautilus/led.c
index 3fab136610..f000d79ec8 100644
--- a/board/nautilus/led.c
+++ b/board/nautilus/led.c
@@ -70,7 +70,7 @@ static void nautilus_led_set_power_battery(void)
{
static unsigned int power_ticks;
enum led_color cur_led_color = LED_RED;
- enum charge_state chg_state = charge_get_state();
+ enum led_pwr_state chg_state = charge_get_state();
int charge_percent = charge_get_percent();
if (chipset_in_state(CHIPSET_STATE_ON)) {
diff --git a/board/rammus/led.c b/board/rammus/led.c
index 5ae415a61a..2a4877b6b1 100644
--- a/board/rammus/led.c
+++ b/board/rammus/led.c
@@ -123,7 +123,7 @@ static void rammus_led_set_power(void)
static void rammus_led_set_battery(void)
{
- enum charge_state chg_state = charge_get_state();
+ enum led_pwr_state chg_state = charge_get_state();
int charge_percent = charge_get_percent();
static unsigned int charge_ticks;