summaryrefslogtreecommitdiff
path: root/board
diff options
context:
space:
mode:
authorTom Hughes <tomhughes@chromium.org>2022-10-14 08:55:18 -0700
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>2022-10-19 20:56:04 +0000
commit0d1b98c7183e8bc058a00ace0c30c1ea0e736a8a (patch)
tree6ff876b5578d5c83285dd90c295f0b697efc238c /board
parente66c6fe6efab16bed9b06c1b9e349c71eddb5a3f (diff)
downloadchrome-ec-0d1b98c7183e8bc058a00ace0c30c1ea0e736a8a.tar.gz
tree: Enable warning for fallthrough in switch statements
The EC code has generally been good about adding comments about intentional fallthrough in switch statements, but there were a few cases without comments (e.g., https://crrev.com/c/3949622). Enabling -Wimplicit-fallthrough generates a compiler warning if the fallthrough is not annotated with __attribute__((fallthrough)). For convenience, we add a "__fallthrough" macro for this attribute. See https://clang.llvm.org/docs/AttributeReference.html#fallthrough and https://gcc.gnu.org/onlinedocs/gcc/Statement-Attributes.html. BRANCH=none BUG=b:253644823 TEST=make buildall LOW_COVERAGE_REASON=legacy code Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I9f4d6049f4507a25ce706675d159b70e28b4b825 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3957420 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Diffstat (limited to 'board')
-rw-r--r--board/boldar/board.c1
-rw-r--r--board/burnet/led.c2
-rw-r--r--board/careena/led.c2
-rw-r--r--board/chronicler/usbc_config.c1
-rw-r--r--board/collis/board.c1
-rw-r--r--board/copano/board.c1
-rw-r--r--board/coral/led.c2
-rw-r--r--board/corori/led.c2
-rw-r--r--board/delbin/board.c1
-rw-r--r--board/drawcia/led.c2
-rw-r--r--board/drawcia_riscv/led.c2
-rw-r--r--board/drobit/board.c1
-rw-r--r--board/eldrid/board.c1
-rw-r--r--board/elemi/board.c1
-rw-r--r--board/haboki/led.c2
-rw-r--r--board/kappa/led.c2
-rw-r--r--board/lantis/led.c2
-rw-r--r--board/lindar/board.c1
-rw-r--r--board/reef/led.c2
-rw-r--r--board/reef_it8320/led.c2
-rw-r--r--board/reef_mchp/led.c2
-rw-r--r--board/voema/board.c1
-rw-r--r--board/volet/board.c1
-rw-r--r--board/voxel/board.c1
24 files changed, 24 insertions, 12 deletions
diff --git a/board/boldar/board.c b/board/boldar/board.c
index 19b8f44020..1076ccc040 100644
--- a/board/boldar/board.c
+++ b/board/boldar/board.c
@@ -474,6 +474,7 @@ void ppc_interrupt(enum gpio_signal signal)
break;
case GPIO_USB_C1_PPC_INT_ODL:
syv682x_interrupt(USBC_PORT_C1);
+ break;
default:
break;
}
diff --git a/board/burnet/led.c b/board/burnet/led.c
index 4aa91c63e2..68c4c9e839 100644
--- a/board/burnet/led.c
+++ b/board/burnet/led.c
@@ -147,7 +147,7 @@ static void led_set_battery(void)
led_set_color_battery(LED_WHITE);
break;
}
- /* Intentional fall-through */
+ __fallthrough;
case PWR_STATE_DISCHARGE:
/*
* Blink white light (1 sec on, 1 sec off)
diff --git a/board/careena/led.c b/board/careena/led.c
index 48a065fdb9..9a280a011b 100644
--- a/board/careena/led.c
+++ b/board/careena/led.c
@@ -110,7 +110,7 @@ static void led_set_battery(void)
led_set_color_battery(LED_WHITE);
break;
}
- /* Intentional fall-through */
+ __fallthrough;
case PWR_STATE_DISCHARGE:
/*
* Blink white light (1 sec on, 1 sec off)
diff --git a/board/chronicler/usbc_config.c b/board/chronicler/usbc_config.c
index b05cd4ecfd..85c40e93e1 100644
--- a/board/chronicler/usbc_config.c
+++ b/board/chronicler/usbc_config.c
@@ -68,6 +68,7 @@ void ppc_interrupt(enum gpio_signal signal)
break;
case GPIO_USB_C1_PPC_INT_ODL:
syv682x_interrupt(USBC_PORT_C1);
+ break;
default:
break;
}
diff --git a/board/collis/board.c b/board/collis/board.c
index 6b2c81bc02..56c67989a5 100644
--- a/board/collis/board.c
+++ b/board/collis/board.c
@@ -270,6 +270,7 @@ void ppc_interrupt(enum gpio_signal signal)
break;
case GPIO_USB_C1_PPC_INT_ODL:
syv682x_interrupt(USBC_PORT_C1);
+ break;
default:
break;
}
diff --git a/board/copano/board.c b/board/copano/board.c
index b4a8c5eb20..8d58fa1101 100644
--- a/board/copano/board.c
+++ b/board/copano/board.c
@@ -310,6 +310,7 @@ void ppc_interrupt(enum gpio_signal signal)
break;
case GPIO_USB_C1_PPC_INT_ODL:
syv682x_interrupt(USBC_PORT_C1);
+ break;
default:
break;
}
diff --git a/board/coral/led.c b/board/coral/led.c
index 8af0f6f3e2..b8515c14c7 100644
--- a/board/coral/led.c
+++ b/board/coral/led.c
@@ -188,7 +188,7 @@ static enum led_states led_get_state(void)
new_state = STATE_CHARGING_LVL_3;
break;
}
- /* Intentional fall-through */
+ __fallthrough;
case PWR_STATE_DISCHARGE /* and PWR_STATE_DISCHARGE_FULL */:
if (chipset_in_state(CHIPSET_STATE_ON))
new_state = STATE_DISCHARGE_S0;
diff --git a/board/corori/led.c b/board/corori/led.c
index 89799c8e74..f47871a4ed 100644
--- a/board/corori/led.c
+++ b/board/corori/led.c
@@ -127,7 +127,7 @@ static enum led_states led_get_state(void)
new_state = STATE_CHARGING_FULL_CHARGE;
break;
}
- /* Intentional fall-through */
+ __fallthrough;
case PWR_STATE_DISCHARGE /* and PWR_STATE_DISCHARGE_FULL */:
if (chipset_in_state(CHIPSET_STATE_ON))
new_state = (led_get_charge_percent() < 10) ?
diff --git a/board/delbin/board.c b/board/delbin/board.c
index 1cdb42d954..28a0c929e2 100644
--- a/board/delbin/board.c
+++ b/board/delbin/board.c
@@ -370,6 +370,7 @@ void ppc_interrupt(enum gpio_signal signal)
break;
case GPIO_USB_C1_PPC_INT_ODL:
syv682x_interrupt(USBC_PORT_C1);
+ break;
default:
break;
}
diff --git a/board/drawcia/led.c b/board/drawcia/led.c
index 8e6263fbbc..0fee248506 100644
--- a/board/drawcia/led.c
+++ b/board/drawcia/led.c
@@ -142,7 +142,7 @@ static void led_set_battery(void)
led_set_color_battery(LED_WHITE);
break;
}
- /* Intentional fall-through */
+ __fallthrough;
case PWR_STATE_DISCHARGE:
/*
* Blink white light (1 sec on, 1 sec off)
diff --git a/board/drawcia_riscv/led.c b/board/drawcia_riscv/led.c
index 3cb7cb835e..d72626b2a2 100644
--- a/board/drawcia_riscv/led.c
+++ b/board/drawcia_riscv/led.c
@@ -142,7 +142,7 @@ static void led_set_battery(void)
led_set_color_battery(LED_WHITE);
break;
}
- /* Intentional fall-through */
+ __fallthrough;
case PWR_STATE_DISCHARGE:
/*
* Blink white light (1 sec on, 1 sec off)
diff --git a/board/drobit/board.c b/board/drobit/board.c
index 19b5162092..1a20870d1f 100644
--- a/board/drobit/board.c
+++ b/board/drobit/board.c
@@ -303,6 +303,7 @@ void ppc_interrupt(enum gpio_signal signal)
break;
case GPIO_USB_C1_PPC_INT_ODL:
syv682x_interrupt(USBC_PORT_C1);
+ break;
default:
break;
}
diff --git a/board/eldrid/board.c b/board/eldrid/board.c
index 717878bc95..81fdf22ffc 100644
--- a/board/eldrid/board.c
+++ b/board/eldrid/board.c
@@ -516,6 +516,7 @@ void ppc_interrupt(enum gpio_signal signal)
break;
case GPIO_USB_C1_PPC_INT_ODL:
syv682x_interrupt(USBC_PORT_C1);
+ break;
default:
break;
}
diff --git a/board/elemi/board.c b/board/elemi/board.c
index 6b166e1206..96860d2335 100644
--- a/board/elemi/board.c
+++ b/board/elemi/board.c
@@ -347,6 +347,7 @@ void ppc_interrupt(enum gpio_signal signal)
break;
case GPIO_USB_C1_PPC_INT_ODL:
syv682x_interrupt(USBC_PORT_C1);
+ break;
default:
break;
}
diff --git a/board/haboki/led.c b/board/haboki/led.c
index b31d4fab75..c6e481e285 100644
--- a/board/haboki/led.c
+++ b/board/haboki/led.c
@@ -142,7 +142,7 @@ static void led_set_battery(void)
led_set_color_battery(LED_WHITE);
break;
}
- /* Intentional fall-through */
+ __fallthrough;
case PWR_STATE_DISCHARGE:
/*
* Blink white light (1 sec on, 1 sec off)
diff --git a/board/kappa/led.c b/board/kappa/led.c
index 1c7979eac0..1dc86013d7 100644
--- a/board/kappa/led.c
+++ b/board/kappa/led.c
@@ -104,7 +104,7 @@ static void led_set_battery(void)
led_set_color_battery(LED_WHITE);
break;
}
- /* Intentional fall-through */
+ __fallthrough;
case PWR_STATE_DISCHARGE:
/*
* Blink white light (1 sec on, 1 sec off)
diff --git a/board/lantis/led.c b/board/lantis/led.c
index d6dbc929a8..3b66ad6d6b 100644
--- a/board/lantis/led.c
+++ b/board/lantis/led.c
@@ -199,7 +199,7 @@ static void led_set_battery(void)
set_active_port_color(LED_WHITE);
break;
}
- /* Intentional fall-through */
+ __fallthrough;
case PWR_STATE_DISCHARGE:
/*
* Blink white/amber light (1 sec on, 1 sec off)
diff --git a/board/lindar/board.c b/board/lindar/board.c
index 5bb155550e..e3ee0ff9c4 100644
--- a/board/lindar/board.c
+++ b/board/lindar/board.c
@@ -479,6 +479,7 @@ void ppc_interrupt(enum gpio_signal signal)
break;
case GPIO_USB_C1_PPC_INT_ODL:
syv682x_interrupt(USBC_PORT_C1);
+ break;
default:
break;
}
diff --git a/board/reef/led.c b/board/reef/led.c
index 95db062d10..8bc52dbc75 100644
--- a/board/reef/led.c
+++ b/board/reef/led.c
@@ -104,7 +104,7 @@ static void led_set_battery(void)
led_set_color_battery(LED_BLUE);
break;
}
- /* Intentional fall-through */
+ __fallthrough;
case PWR_STATE_DISCHARGE /* and PWR_STATE_DISCHARGE_FULL */:
if (chipset_in_state(CHIPSET_STATE_ON)) {
led_set_color_battery(LED_BLUE);
diff --git a/board/reef_it8320/led.c b/board/reef_it8320/led.c
index 1b521b9409..630fdf336d 100644
--- a/board/reef_it8320/led.c
+++ b/board/reef_it8320/led.c
@@ -105,7 +105,7 @@ static void led_set_battery(void)
led_set_color_battery(LED_BLUE);
break;
}
- /* Intentional fall-through */
+ __fallthrough;
case PWR_STATE_DISCHARGE /* and PWR_STATE_DISCHARGE_FULL */:
if (chipset_in_state(CHIPSET_STATE_ON)) {
led_set_color_battery(LED_BLUE);
diff --git a/board/reef_mchp/led.c b/board/reef_mchp/led.c
index 469758dc26..96ea6bb958 100644
--- a/board/reef_mchp/led.c
+++ b/board/reef_mchp/led.c
@@ -105,7 +105,7 @@ static void led_set_battery(void)
led_set_color_battery(LED_BLUE);
break;
}
- /* Intentional fall-through */
+ __fallthrough;
case PWR_STATE_DISCHARGE /* and PWR_STATE_DISCHARGE_FULL */:
if (chipset_in_state(CHIPSET_STATE_ON)) {
led_set_color_battery(LED_BLUE);
diff --git a/board/voema/board.c b/board/voema/board.c
index c4563df105..363cc603ad 100644
--- a/board/voema/board.c
+++ b/board/voema/board.c
@@ -309,6 +309,7 @@ void ppc_interrupt(enum gpio_signal signal)
break;
case GPIO_USB_C1_PPC_INT_ODL:
syv682x_interrupt(USBC_PORT_C1);
+ break;
default:
break;
}
diff --git a/board/volet/board.c b/board/volet/board.c
index 474ec9cb0e..47140464b6 100644
--- a/board/volet/board.c
+++ b/board/volet/board.c
@@ -369,6 +369,7 @@ void ppc_interrupt(enum gpio_signal signal)
break;
case GPIO_USB_C1_PPC_INT_ODL:
syv682x_interrupt(USBC_PORT_C1);
+ break;
default:
break;
}
diff --git a/board/voxel/board.c b/board/voxel/board.c
index 40dfbe8dc4..4c8badeb1c 100644
--- a/board/voxel/board.c
+++ b/board/voxel/board.c
@@ -367,6 +367,7 @@ void ppc_interrupt(enum gpio_signal signal)
break;
case GPIO_USB_C1_PPC_INT_ODL:
syv682x_interrupt(USBC_PORT_C1);
+ break;
default:
break;
}
View Lorry Controller Status