diff options
author | Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com> | 2015-06-18 23:47:43 -0700 |
---|---|---|
committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-06-25 17:21:50 +0000 |
commit | ddf77bbe785a5ae1c701ef70fb6e41a89168e341 (patch) | |
tree | 9b47d735af60c1a5a34224189885f72666539184 /board | |
parent | 331db691c418e607b9830ba96e6ca1b634c7cea4 (diff) | |
download | chrome-ec-ddf77bbe785a5ae1c701ef70fb6e41a89168e341.tar.gz |
Fix assertion crash in __wait_evt()
mutex_lock() is called from MEC1322_IRQ_ACPIEC0_IBF
interrupt context, causing deadlock and assertion
in __wait_evt().
In the interrupt context it now checks for mutex lock first.
If the mutex is already locked,, it will disable ACPI
interrupts and defer the memmap mutex lock.
Added LPC interrupt disable/enable functions as needed.
Increased deferred function count where needed.
BRANCH=None
BUG=chrome-os-partner:40820
TEST=Test for suspend-resume, cold, warm reboots and
other general stability.
Change-Id: I3dda0d4635a6b6281faf200c8c7b6fcba8877254
Signed-off-by: Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/280418
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>
Commit-Queue: Divya Jyothi <divya.jyothi@intel.com>
Tested-by: Divya Jyothi <divya.jyothi@intel.com>
Diffstat (limited to 'board')
-rw-r--r-- | board/glados/board.h | 2 | ||||
-rw-r--r-- | board/rambi/board.h | 3 | ||||
-rw-r--r-- | board/samus/board.h | 2 |
3 files changed, 5 insertions, 2 deletions
diff --git a/board/glados/board.h b/board/glados/board.h index 6768b61749..4762f3916c 100644 --- a/board/glados/board.h +++ b/board/glados/board.h @@ -75,7 +75,7 @@ #define I2C_PORT_USB_CHARGER_2 MEC1322_I2C3 #undef DEFERRABLE_MAX_COUNT -#define DEFERRABLE_MAX_COUNT 10 +#define DEFERRABLE_MAX_COUNT 11 #ifndef __ASSEMBLER__ diff --git a/board/rambi/board.h b/board/rambi/board.h index 84d378d4df..f08e6a0266 100644 --- a/board/rambi/board.h +++ b/board/rambi/board.h @@ -48,6 +48,9 @@ #define CONFIG_WIRELESS_SUSPEND \ (EC_WIRELESS_SWITCH_WLAN | EC_WIRELESS_SWITCH_WLAN_POWER) +#undef DEFERRABLE_MAX_COUNT +#define DEFERRABLE_MAX_COUNT 9 + #ifndef __ASSEMBLER__ /* I2C ports */ diff --git a/board/samus/board.h b/board/samus/board.h index f1eb461c27..ee793ff8d2 100644 --- a/board/samus/board.h +++ b/board/samus/board.h @@ -81,7 +81,7 @@ /* Do we want EC_WIRELESS_SWITCH_WWAN as well? */ #undef DEFERRABLE_MAX_COUNT -#define DEFERRABLE_MAX_COUNT 9 +#define DEFERRABLE_MAX_COUNT 10 #ifndef __ASSEMBLER__ |