diff options
author | Bernard Shyu <bernard_shyu@bizlinktech.com> | 2014-11-19 19:05:34 +0800 |
---|---|---|
committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-11-19 23:17:44 +0000 |
commit | 1e9491e07db038541d9c707d081aad83bb1ace5d (patch) | |
tree | dfc186858121059a90ab7ce6271692ebb853786c /board | |
parent | 6be0040bbe0316058330392fe7327ff0c58e5081 (diff) | |
download | chrome-ec-1e9491e07db038541d9c707d081aad83bb1ace5d.tar.gz |
usb_pd: SVDM DP protocol definition errors
The role of hoho & dingdong is UFP, and the corresponding protocol
fields in VDO (vdo_idh) should reflect it.
Fix error in IDH_PTYPE definitions of SVDM Identity Header, it's reversed
Adds more legible names to protocol field constants
BUG=none
BRANCH=none
TEST=make buildall
Change-Id: Idac9327bf3e8e9597221654bce80bb311b3304af
Reviewed-on: https://chromium-review.googlesource.com/230657
Reviewed-by: Alec Berg <alecaberg@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>
Commit-Queue: Bernard Shyu <bernard_shyu@bizlinktech.com>
Tested-by: Bernard Shyu <bernard_shyu@bizlinktech.com>
Diffstat (limited to 'board')
-rw-r--r-- | board/dingdong/usb_pd_policy.c | 2 | ||||
-rw-r--r-- | board/hoho/usb_pd_policy.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/board/dingdong/usb_pd_policy.c b/board/dingdong/usb_pd_policy.c index d082f99c60..63223d8927 100644 --- a/board/dingdong/usb_pd_policy.c +++ b/board/dingdong/usb_pd_policy.c @@ -139,7 +139,7 @@ void pd_new_contract(int port, int pr_role, int dr_role, } /* ----------------- Vendor Defined Messages ------------------ */ const uint32_t vdo_idh = VDO_IDH(0, /* data caps as USB host */ - 0, /* data caps as USB device */ + 1, /* data caps as USB device */ IDH_PTYPE_AMA, /* Alternate mode */ 1, /* supports alt modes */ USB_VID_GOOGLE); diff --git a/board/hoho/usb_pd_policy.c b/board/hoho/usb_pd_policy.c index adb3e1ddc4..6098c790c1 100644 --- a/board/hoho/usb_pd_policy.c +++ b/board/hoho/usb_pd_policy.c @@ -139,7 +139,7 @@ void pd_new_contract(int port, int pr_role, int dr_role, } /* ----------------- Vendor Defined Messages ------------------ */ const uint32_t vdo_idh = VDO_IDH(0, /* data caps as USB host */ - 0, /* data caps as USB device */ + 1, /* data caps as USB device */ IDH_PTYPE_AMA, /* Alternate mode */ 1, /* supports alt modes */ USB_VID_GOOGLE); |